You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/22 01:02:24 UTC
[GitHub] [beam] dsmilkov opened a new pull request, #23326: Update setup.py
dsmilkov opened a new pull request, #23326:
URL: https://github.com/apache/beam/pull/23326
Remove redundant pip check which causes installation failure when using `poetry` for package management. See https://github.com/python-poetry/poetry/issues/4888
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23326: Relax `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1263783212
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1256275529
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23326: Relax `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1261659495
LGTM, we can merge when tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dsmilkov commented on pull request #23326: Relax `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
dsmilkov commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1263499939
Ping @tvalentyn @Abacn . Tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #23326: Relax `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #23326:
URL: https://github.com/apache/beam/pull/23326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1254392849
# [Codecov](https://codecov.io/gh/apache/beam/pull/23326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23326](https://codecov.io/gh/apache/beam/pull/23326?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13bbe3f) into [master](https://codecov.io/gh/apache/beam/commit/3fe0867cd678086c55376c6080e06bdfc99e48a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3fe0867) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23326 +/- ##
=======================================
Coverage 73.41% 73.41%
=======================================
Files 718 718
Lines 95620 95616 -4
=======================================
+ Hits 70195 70196 +1
+ Misses 24114 24109 -5
Partials 1311 1311
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.18% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/23326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/23326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.71% <0.00%> (-0.31%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/23326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=) | `88.59% <0.00%> (-0.25%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/23326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/23326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.54% <0.00%> (+0.12%)` | :arrow_up: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/23326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `93.08% <0.00%> (+0.64%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #23326:
URL: https://github.com/apache/beam/pull/23326#discussion_r977157154
##########
sdks/python/setup.py:
##########
@@ -95,16 +95,6 @@ def get_version():
different technologies and user communities.
'''
-REQUIRED_PIP_VERSION = '7.0.0'
Review Comment:
The context was here: https://github.com/apache/beam/issues/22218#issuecomment-1196014115. We may change REQUIRED_PIP_VERSION -> RECOMMENDED_MIN_PIP_VERSION and change the warning accordingly. And put the code in a try clause and catch `DistributionNotFound`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #23326:
URL: https://github.com/apache/beam/pull/23326#discussion_r977157154
##########
sdks/python/setup.py:
##########
@@ -95,16 +95,6 @@ def get_version():
different technologies and user communities.
'''
-REQUIRED_PIP_VERSION = '7.0.0'
Review Comment:
The context was here: https://github.com/apache/beam/issues/22218#issuecomment-1196014115. We may change REQUIRED_PIP_VERSION -> RECOMMENDED_MIN_PIP_VERSION and change the warning accordingly. And put the code in a try clause and catch `DistributionNotFound` as the cython version logics below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1254463374
agree this code is far outdated.
On the other side there was recently an issue of pypi dependency backoff with gcp dependencies and got mitigated. Maybe we still want some warning but update the recommended version number and phrasing, and also make sure this does not fail when there is no pypi (add None check or so). @tvalentyn may have more context about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1256281142
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23326: Relax `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1261659619
please ping the PR if not merged tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23326:
URL: https://github.com/apache/beam/pull/23326#issuecomment-1254400715
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @yeandy for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dsmilkov commented on a diff in pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
dsmilkov commented on code in PR #23326:
URL: https://github.com/apache/beam/pull/23326#discussion_r978703557
##########
sdks/python/setup.py:
##########
@@ -95,16 +95,6 @@ def get_version():
different technologies and user communities.
'''
-REQUIRED_PIP_VERSION = '7.0.0'
Review Comment:
That sounds better and more robust. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #23326:
URL: https://github.com/apache/beam/pull/23326#discussion_r978724700
##########
sdks/python/setup.py:
##########
@@ -95,16 +95,6 @@ def get_version():
different technologies and user communities.
'''
-REQUIRED_PIP_VERSION = '7.0.0'
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org