You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/13 10:33:18 UTC
[GitHub] [airflow] jbampton opened a new pull request #13040: Add HTML meta tags. Set the dir attribute to ltr on the opening html tag
jbampton opened a new pull request #13040:
URL: https://github.com/apache/airflow/pull/13040
The dir attribute specifies the text direction of the element's content. Set at left to right.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13040: Add HTML meta tags. Set the dir attribute to ltr on the opening html tag
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13040:
URL: https://github.com/apache/airflow/pull/13040#issuecomment-772755672
Closing this PR; there isn't any clear or presented value to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13040: Add HTML meta tags. Set the dir attribute to ltr on the opening html tag
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13040:
URL: https://github.com/apache/airflow/pull/13040#issuecomment-748234870
@jbampton the function of the `dir` attribute is understood, but why are they necessary for this application and specifically these views?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jbampton commented on pull request #13040: Add HTML meta tags. Set the dir attribute to ltr on the opening html tag
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #13040:
URL: https://github.com/apache/airflow/pull/13040#issuecomment-747355754
Hey @potiuk can you please review 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton closed pull request #13040: Add HTML meta tags. Set the dir attribute to ltr on the opening html tag
Posted by GitBox <gi...@apache.org>.
ryanahamilton closed pull request #13040:
URL: https://github.com/apache/airflow/pull/13040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13040: Add HTML meta tags. Set the dir attribute to ltr on the opening html tag
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13040:
URL: https://github.com/apache/airflow/pull/13040#issuecomment-747397058
Not a big expert in the frontend part and there some frontend changes there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org