You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 17:33:23 UTC
[GitHub] [arrow] xhochy opened a new pull request #8881: WIP: Fix Windows wheel
xhochy opened a new pull request #8881:
URL: https://github.com/apache/arrow/pull/8881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743141374
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#discussion_r542327786
##########
File path: dev/tasks/python-wheels/win-build.bat
##########
@@ -46,32 +47,30 @@ pushd arrow\cpp\build
cmake -A "%ARCH%" ^
-G "%GENERATOR%" ^
- -DCMAKE_INSTALL_PREFIX=%ARROW_HOME% ^
- -DARROW_BOOST_USE_SHARED=OFF ^
-DARROW_BUILD_STATIC=OFF ^
-DARROW_BUILD_TESTS=OFF ^
- -DCMAKE_BUILD_TYPE=Release ^
- -DARROW_DEPENDENCY_SOURCE=CONDA ^
- -DOPENSSL_ROOT_DIR=%CONDA_PREFIX%/Library ^
-DARROW_CXXFLAGS="/MP" ^
- -DARROW_WITH_BZ2=OFF ^
- -DARROW_WITH_ZLIB=ON ^
- -DARROW_WITH_ZSTD=ON ^
- -DARROW_WITH_LZ4=ON ^
- -DARROW_WITH_SNAPPY=ON ^
- -DARROW_WITH_BROTLI=ON ^
-DARROW_DATASET=ON ^
+ -DARROW_DEPENDENCY_SOURCE=BUNDLED ^
-DARROW_FLIGHT=ON ^
-DARROW_GANDIVA=OFF ^
- -DARROW_LZ4_USE_SHARED=OFF ^
-DARROW_MIMALLOC=ON ^
+ -DARROW_OPENSSL_USE_SHARED=OFF ^
-DARROW_PARQUET=ON ^
+ -DARROW_PROTOBUF_USE_SHARED=OFF ^
Review comment:
Should `ARROW_DEPENDENCY_USE_SHARED` be enough to set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743142159
Revision: 24258fd948531e3dc680e51dad1bcc5149c2a4bf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-777](https://github.com/ursa-labs/crossbow/branches/all?query=actions-777)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-777-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-741943089
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744500994
@github-actions autotune
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743169790
Revision: e9cb1b040063c782066ea892b3501bfa0042bd26
Submitted crossbow builds: [ursa-labs/crossbow @ actions-778](https://github.com/ursa-labs/crossbow/branches/all?query=actions-778)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-778-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743208447
Revision: 52e38a32855b3134535dfabb108bef5c737b81c0
Submitted crossbow builds: [ursa-labs/crossbow @ actions-779](https://github.com/ursa-labs/crossbow/branches/all?query=actions-779)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-779-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756518621
Revision: 393da6f2b0ae44fe731254f2ef623df64891047d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-843](https://github.com/ursa-labs/crossbow/branches/all?query=actions-843)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-843-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756179404
Revision: 2367ec547bcba673d31dccd14f1e29762cb778bd
Submitted crossbow builds: [ursa-labs/crossbow @ actions-832](https://github.com/ursa-labs/crossbow/branches/all?query=actions-832)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-832-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756075091
Revision: b594fde2a4fe3fdbfbbd3ef44d76352ba9e3211a
Submitted crossbow builds: [ursa-labs/crossbow @ actions-829](https://github.com/ursa-labs/crossbow/branches/all?query=actions-829)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-829-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8881:
URL: https://github.com/apache/arrow/pull/8881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742412628
Revision: bdb5df7887dd34bdaa15e583b934d498019278b8
Submitted crossbow builds: [ursa-labs/crossbow @ actions-761](https://github.com/ursa-labs/crossbow/branches/all?query=actions-761)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-761-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743728168
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756450988
@kszucs can this be merged now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743099217
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-755588630
@xhochy what's the status of this? Fixing windows wheels is one of our (several) release blockers. Is rebase all that is needed to be able to merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743721110
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy closed pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy closed pull request #8881:
URL: https://github.com/apache/arrow/pull/8881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744663619
Seems like we are building our own gRPC but then use the headers from the MinGW-provided ones, just another case of the RE2 vs re2 weirdness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742454981
Revision: d1dea6a417eba6131b3b5400fe4ce600065ade77
Submitted crossbow builds: [ursa-labs/crossbow @ actions-763](https://github.com/ursa-labs/crossbow/branches/all?query=actions-763)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-763-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756138141
Something went wrong with the crossbow task. It should have triggered a build on Github Actions but it didn't create the appropriate CI files in the branch. @kszucs can you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-741929836
Revision: 19f504ae0ef417c0ee6003973837862efc64f7a2
Submitted crossbow builds: [ursa-labs/crossbow @ actions-754](https://github.com/ursa-labs/crossbow/branches/all?query=actions-754)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-754-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744514535
Revision: 5e29b5ff6091be517666366f188feabb36f653f5
Submitted crossbow builds: [ursa-labs/crossbow @ actions-790](https://github.com/ursa-labs/crossbow/branches/all?query=actions-790)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-790-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742492298
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743716412
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744061812
Revision: dfc2e8adbdc1a9a870bd22eecc57e470000c29a2
Submitted crossbow builds: [ursa-labs/crossbow @ actions-784](https://github.com/ursa-labs/crossbow/branches/all?query=actions-784)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-784-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744711052
@kou Nice, I'll then just wait on the merge of #8908 and will then rebase (and revert some of the changes here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742573626
Revision: d548b72b57149d0b4267c4cd0754129c9623861d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-766](https://github.com/ursa-labs/crossbow/branches/all?query=actions-766)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-766-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742411615
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-741986031
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-755791646
INFRA needs to set a new secret for the bot https://issues.apache.org/jira/browse/INFRA-21280
Until that please use crossbow locally:
```bash
# have arrow and crossbow repositories in the same directory next to each other (or use the cli option with explicit paths)
python dev/tasks/crossbow.py submit wheel-win-cp38
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744706504
> Seems like we are building our own gRPC but then use the headers from the MinGW-provided ones, just another case of the RE2 vs re2 weirdness.
Doesn't make a difference with the system gRPC 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743716563
Revision: 48c7548689114497174ba4b51f2013afcbb89906
Submitted crossbow builds: [ursa-labs/crossbow @ actions-780](https://github.com/ursa-labs/crossbow/branches/all?query=actions-780)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-780-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742516297
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756513360
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743169035
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743117986
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744583548
@xhochy This looks like a protobuf version mismatch perhaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756163795
It may need more scopes enabled, looking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742361428
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744280442
Revision: c6eb810f2f400f754322dc1ec3812cb25b3a8a58
Submitted crossbow builds: [ursa-labs/crossbow @ actions-788](https://github.com/ursa-labs/crossbow/branches/all?query=actions-788)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-788-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744709885
#8908 solves the MinGW build failures. It's caused by signature change in gRPC (`grpc::protobuf::Message` -> `grpc::protobuf::MessageLite`): https://github.com/apache/arrow/pull/8908/files#diff-00ed5e81d6488cc38237bbba649ca625d679cf6035a90f15341db7d25e73602a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744324594
@kou @kszucs PTAL. I would like to merge this to get the CI fixed and then rebase https://github.com/apache/arrow/pull/8878 on top of that. There I might remove the conda dependency completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742454261
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742493048
Revision: 774d91c8cabaee63d5da57269d761acea4fb3f68
Submitted crossbow builds: [ursa-labs/crossbow @ actions-764](https://github.com/ursa-labs/crossbow/branches/all?query=actions-764)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-764-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744503530
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744542347
@kou Do you have an idea what would be causing the MinGW failures?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744324924
@github-actions crossbow submit -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743721270
Revision: f652dcd389ffc9223a2022747b1bcb7538d1849a
Submitted crossbow builds: [ursa-labs/crossbow @ actions-781](https://github.com/ursa-labs/crossbow/branches/all?query=actions-781)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-781-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743118842
Revision: 7a27bb2395cb119933eab29762e4567c0bd3508e
Submitted crossbow builds: [ursa-labs/crossbow @ actions-776](https://github.com/ursa-labs/crossbow/branches/all?query=actions-776)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-776-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742519672
Revision: 547a693955dc3fa9d15793468c9431e86d6b7bab
Submitted crossbow builds: [ursa-labs/crossbow @ actions-765](https://github.com/ursa-labs/crossbow/branches/all?query=actions-765)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-765-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744061628
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743728310
Revision: 31a060841747fbea16fd93e17b1be367817073c2
Submitted crossbow builds: [ursa-labs/crossbow @ actions-782](https://github.com/ursa-labs/crossbow/branches/all?query=actions-782)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-782-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742435860
Revision: 4d5d7c0cca7b593fea10560a28af69abd3ac19d9
Submitted crossbow builds: [ursa-labs/crossbow @ actions-762](https://github.com/ursa-labs/crossbow/branches/all?query=actions-762)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-762-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-741987671
Revision: d07f3c506208255835834caf059a4ee143d09598
Submitted crossbow builds: [ursa-labs/crossbow @ actions-757](https://github.com/ursa-labs/crossbow/branches/all?query=actions-757)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-757-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#discussion_r542858526
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2465,20 +2490,35 @@ macro(build_grpc)
string(REPLACE ";" "|" GRPC_PREFIX_PATH_ALT_SEP "${GRPC_CMAKE_PREFIX}")
set(GRPC_CMAKE_ARGS
+ -DBUILD_SHARED_LIBS=OFF
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
+ -DCMAKE_CXX_FLAGS=${GRPC_CMAKE_CXX_FLAGS}
Review comment:
Can we use `EP_COMMON_CMAKE_ARGS` for `GRPC_CMAKE_ARGS`?
It seems that https://github.com/grpc/grpc/issues/13856 has been fixed in gRPC 1.33.1 or later.
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2411,7 +2432,11 @@ macro(build_grpc)
set(
GRPC_STATIC_LIBRARY_UPB
"${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}upb${CMAKE_STATIC_LIBRARY_SUFFIX}")
- set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin")
+ if(MSVC)
+ set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin.exe")
+ else()
+ set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin")
+ endif()
Review comment:
Can we use `CMAKE_EXECUTABLE_SUFFIX` here?
https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html
```suggestion
set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin${CMAKE_EXECUTABLE_SUFFIX}")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-755689064
I can rebase and see whether there is progress but it might still have issues and I had hopes for #9096 to land in time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-741926775
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742393667
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756163795
It may need more scopes, looking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742423863
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-755791646
INFRA needs to set a new secret for the bot https://issues.apache.org/jira/browse/INFRA-21280
Until that please use crossbow locally:
```bash
python dev/tasks/crossbow.py submit wheel-win-cp38
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742363030
Revision: b723f0cd2bdcf729d581250600164e6f265c3dd5
Submitted crossbow builds: [ursa-labs/crossbow @ actions-760](https://github.com/ursa-labs/crossbow/branches/all?query=actions-760)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-760-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744349654
Revision: c6eb810f2f400f754322dc1ec3812cb25b3a8a58
Submitted crossbow builds: [ursa-labs/crossbow @ actions-789](https://github.com/ursa-labs/crossbow/branches/all?query=actions-789)
|Task|Status|
|----|------|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-789-azure-wheel-manylinux2014-cp38)|
|wheel-osx-high-sierra-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-high-sierra-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-high-sierra-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-mavericks-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-mavericks-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-mavericks-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp36m|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-789-github-wheel-win-cp36m)|
|wheel-win-cp37m|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-789-github-wheel-win-cp37m)|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-789-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756165828
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756538003
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-741949800
Revision: 6e531ba7d6a5958384b96a104bbc6c7abc479dd9
Submitted crossbow builds: [ursa-labs/crossbow @ actions-755](https://github.com/ursa-labs/crossbow/branches/all?query=actions-755)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-755-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743099949
Revision: 7a27bb2395cb119933eab29762e4567c0bd3508e
Submitted crossbow builds: [ursa-labs/crossbow @ actions-775](https://github.com/ursa-labs/crossbow/branches/all?query=actions-775)
|Task|Status|
|----|------|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-775-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-756066873
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-742572138
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744262038
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744350531
https://issues.apache.org/jira/browse/ARROW-9400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-744345416
@github-actions autotune everything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-755713376
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#discussion_r553702785
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2124,9 +2124,20 @@ macro(build_re2)
set_target_properties(re2::re2
PROPERTIES IMPORTED_LOCATION "${RE2_STATIC_LIB}"
INTERFACE_INCLUDE_DIRECTORIES "${RE2_PREFIX}/include")
+ if(NOT TARGET re2::re2)
+ add_library(re2::re2 STATIC IMPORTED)
+ set_target_properties(
+ re2::re2
+ PROPERTIES IMPORTED_LOCATION "${RE2_STATIC_LIB}" INTERFACE_INCLUDE_DIRECTORIES
+ "${RE2_PREFIX}/include")
+ endif()
Review comment:
Can we remove this because we always add `re2::re2` library at the above line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#issuecomment-743207468
@github-actions crossbow submit wheel-win-cp38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org