You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by cpoerschke <gi...@git.apache.org> on 2015/06/30 21:07:29 UTC

[GitHub] lucene-solr pull request: support SortingMergePolicy-free use of E...

GitHub user cpoerschke opened a pull request:

    https://github.com/apache/lucene-solr/pull/175

    support SortingMergePolicy-free use of EarlyTerminatingSortingCollector

    for https://issues.apache.org/jira/i#browse/LUCENE-6646


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-sort-outline-lucene

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #175
    
----
commit 5984692c660b32ddec0260e5a096b7b7eea5ea8d
Author: Christine Poerschke <cp...@bloomberg.net>
Date:   2015-06-29T15:02:44Z

    LUCENE-????: support SortingMergePolicy-free use of EarlyTerminatingSortingCollector
    
    motivation:
     * SOLR-5730 to make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr.
     * outline of draft SOLR-5730 changes:
       + SolrIndexWriter constructor calls SolrIndexConfig.toIndexWriterConfig (passing the result to its lucene.IndexWriter super class)
       + SolrIndexConfig.toIndexWriterConfig(SolrCore core) calls SolrIndexConfig.buildMergePolicy
       + SolrIndexConfig.buildMergePolicy(IndexSchema schema) calls the SortingMergePolicy constructor (using the IndexSchema's mergeSortSpec)
       + SolrIndexSearcher.buildAndRunCollectorChain calls the EarlyTerminatingSortingCollector constructor (using the IndexSchema's mergeSortSpec)
    
    summary of changes:
     * added static isSorted variant to SortingMergePolicy
     * added SortingMergePolicy-free EarlyTerminatingSortingCollector constructor variant
     * added SortingMergePolicy-free EarlyTerminatingSortingCollector.canEarlyTerminate variant
     * corresponding changes to TestEarlyTerminatingSortingCollector (randomly choose between constructor and canEarlyTerminate variants)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

[GitHub] lucene-solr pull request: support SortingMergePolicy-free use of E...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucene-solr/pull/175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org