[jira] [Work logged] (HIVE-27332) Add retry backoff mechanism for abort cleanup

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-27332?focusedWorklogId=861538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861538 ]

ASF GitHub Bot logged work on HIVE-27332:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/23 14:10
            Start Date: 11/May/23 14:10
    Worklog Time Spent: 10m 
      Work Description: SourabhBadhya opened a new pull request, #4313:
URL: https://github.com/apache/hive/pull/4313

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Add retry backoff mechanism for abort cleanup
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   To add retry backoff mechanism for abort cleanup
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Unit tests




Issue Time Tracking
-------------------

            Worklog Id:     (was: 861538)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add retry backoff mechanism for abort cleanup
> ---------------------------------------------
>
>                 Key: HIVE-27332
>                 URL: https://issues.apache.org/jira/browse/HIVE-27332
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sourabh Badhya
>            Assignee: Sourabh Badhya
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HIVE-27019 and HIVE-27020 added the functionality to directly clean data directories from aborted transactions without using Initiator & Worker. However, during the event of continuous failure during cleanup, the retry mechanism is initiated every single time. We need to add retry backoff mechanism to control the time required to initiate retry again and not continuously retry.
> There are widely 3 cases wherein retry due to abort cleanup is impacted - 
> *1. Abort cleanup on the table failed + Compaction on the table failed.*
> *2. Abort cleanup on the table failed + Compaction on the table passed*
> *3. Abort cleanup on the table failed + No compaction on the table.*
> *Solution -* 
> *We create a new table called TXN_CLEANUP_QUEUE with following fields to store the retry metadata -* 
> CREATE TABLE TXN_CLEANUP_QUEUE (
> TCQ_DATABASE varchar(128) NOT NULL, 
> TCQ_TABLE varchar(256) NOT NULL,
> TCQ_PARTITION varchar(767), 
> TCQ_RETRY_RETENTION bigint NOT NULL DEFAULT 0, 
> TCQ_ERROR_MESSAGE mediumtext in MySQL / clob in derby, oracle DB / text in postgres / varchar(max) in mssql DB
> );
> *Advantage: Separates the flow of metadata. We also eliminate the chance of breaking the compaction/abort cleanup when modifying metadata of abort cleanup/compaction. Easier debugging in case of failures.*
> *Actions performed by TaskHandler in the case of failure -* 
> *AbortTxnCleaner -* 
> Action: Just add retry details in the queue table during the abort failure.
> *CompactionCleaner -* 
> Action: If compaction on the same table is successful, delete the retry entry in markCleaned when removing any TXN_COMPONENTS entries except when there are no uncompacted aborts. We do not want to be in a situation where there is a queue entry for a table but there is no record in TXN_COMPONENTS associated with the same table.
> *Advantage: Expecting no performance issues with this approach. Since we delete 1 record most of the times for the associated table/partition.*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)