[GitHub] [beam] Abacn commented on a diff in pull request #24015: [Bigtable] Migrate BigtableIO to use the veneer client under the hood

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #24015:
URL: https://github.com/apache/beam/pull/24015#discussion_r1114539627


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java:
##########
@@ -424,66 +447,6 @@ private static KV<ByteString, Iterable<Mutation>> makeBadWrite(String key) {
     return KV.of(ByteString.copyFromUtf8(key), mutations);
   }
 
-  /** Tests that credentials are used from PipelineOptions if not supplied by BigtableOptions. */
-  @Test

Review Comment:
   Just wondering the purpose of removing these unit tests, is it because the scenario is no longer applicable for the new client, or are there any breaking change / regression could be introduced?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org