You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by Todd Lipcon <to...@cloudera.com> on 2010/09/10 05:27:49 UTC

Review Request: Refactor master command line to a new class

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/811/
-----------------------------------------------------------

Review request for hbase, stack and Jonathan Gray.


Summary
-------

Straight refactor... more stuff like this coming, but this one should be noncontroversial.


This addresses bug HBASE-2977.
    http://issues.apache.org/jira/browse/HBASE-2977


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 2ac2c59 
  src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java PRE-CREATION 

Diff: http://review.cloudera.org/r/811/diff


Testing
-------

Managed to start a master same as before.


Thanks,

Todd

Re: Review Request: Refactor master command line to a new class

Posted by st...@duboce.net.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/811/#review1145
-----------------------------------------------------------

Ship it!


+1

One minor item below -- take it or leave it


src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
<http://review.cloudera.org/r/811/#comment3947>

    Suggest MasterCommandLine rather than H* (I hate the 'H' in front of everything)


- stack


On 2010-09-09 20:27:48, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/811/
> -----------------------------------------------------------
> 
> (Updated 2010-09-09 20:27:48)
> 
> 
> Review request for hbase, stack and Jonathan Gray.
> 
> 
> Summary
> -------
> 
> Straight refactor... more stuff like this coming, but this one should be noncontroversial.
> 
> 
> This addresses bug HBASE-2977.
>     http://issues.apache.org/jira/browse/HBASE-2977
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 2ac2c59 
>   src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java PRE-CREATION 
> 
> Diff: http://review.cloudera.org/r/811/diff
> 
> 
> Testing
> -------
> 
> Managed to start a master same as before.
> 
> 
> Thanks,
> 
> Todd
> 
>