You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lovexi <gi...@git.apache.org> on 2016/07/29 23:52:15 UTC
[GitHub] spark pull request #14415: [SPARK-16810] Refactor registerSinks with multipl...
GitHub user lovexi opened a pull request:
https://github.com/apache/spark/pull/14415
[SPARK-16810] Refactor registerSinks with multiple constructos
## What changes were proposed in this pull request?
For some metrics, it may require some **app detailed information** from `SparkConf`. So for those sinks, we need to pass `SparkConf` via sink constructor. Refactored registerSink class reflection part to allow multiple types of sink constructor to be initialized.
## How was this patch tested?
Using existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lovexi/spark yangyang-metric-system
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14415
----
commit 943cf4d29c04f3148a468be88e68b572d2a761fc
Author: Yangyang Liu <ya...@fb.com>
Date: 2016-07-29T23:45:06Z
Refactor registerSinks with multiple constructos
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Posted by lovexi <gi...@git.apache.org>.
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14415
@rxin I was trying to add a unit test for this feature. But the test sinks are not visible for `MetricsSystem` when it tries to register test sink classes since test sinks are hidden in test packages. Is there any other ways to load test classes for `MetricsSystem` without messed-up metrics package?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14415
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14415: [SPARK-16810] Refactor registerSinks with multipl...
Posted by lovexi <gi...@git.apache.org>.
Github user lovexi closed the pull request at:
https://github.com/apache/spark/pull/14415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14415
DId you add a test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Posted by lovexi <gi...@git.apache.org>.
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14415
Oops. I kind of messed up here. Going to open another PR for this. Close this for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org