You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "mneethiraj (via GitHub)" <gi...@apache.org> on 2025/10/27 23:09:10 UTC
[PR] RANGER-5386: Docker setup updated to use latest Trino release [ranger]
mneethiraj opened a new pull request, #719:
URL: https://github.com/apache/ranger/pull/719
## What changes were proposed in this pull request?
- updated docker setup to use the latest Trino release, instead of Trino version 435
- removed the steps to install Ranger authorization plugin, since the plugin is now builti into Trino release
- updated the steps to configure Ranger plugin, by copying necessary files into /etc/trino directory
- adds catalog 'hive' that uses HMS deployed in ranger-hive container
## How was this patch tested?
Verified that Trino container starts successfully with Ranger registered as the authorizer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5386: Docker setup updated to use latest Trino release [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on code in PR #719:
URL: https://github.com/apache/ranger/pull/719#discussion_r2467633028
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
-ENV PLUGIN_DIR=ranger-${TRINO_PLUGIN_VERSION}-trino-plugin
-RUN mkdir -p /home/ranger/dist /home/ranger/scripts /opt/ranger
+RUN mkdir -p /home/ranger/scripts/
-COPY ./dist/version /home/ranger/dist
-COPY ./dist/ranger-${TRINO_PLUGIN_VERSION}-trino-plugin.tar.gz /home/ranger/dist
-COPY ./scripts/ranger-trino.sh /home/ranger/scripts
-COPY ./scripts/ranger-trino-setup.sh /home/ranger/scripts
-COPY ./scripts/ranger-trino-plugin-install.properties /home/ranger/scripts
+COPY ./scripts/access-control.properties /etc/trino/
Review Comment:
Good suggestion. I updated the PR to reflect this suggestion. We should refactor other config and script files similarly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5386: Docker setup updated to use latest Trino release [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on code in PR #719:
URL: https://github.com/apache/ranger/pull/719#discussion_r2467633308
##########
dev-support/ranger-docker/config/trino/access-control.properties:
##########
@@ -0,0 +1,4 @@
+access-control.name=ranger
+
+ranger.service.name=dev_trino
+ranger.plugin.config.resource=/etc/trino/ranger-trino-security.xml,/etc/trino/ranger-trino-audit.xml
Review Comment:
Done.
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5386: Docker setup updated to use latest Trino release [ranger]
Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #719:
URL: https://github.com/apache/ranger/pull/719#issuecomment-3454364631
Also, I think it is okay to keep trino excluded from the docker build in the CI pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5386: Docker setup updated to use latest Trino release [ranger]
Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on code in PR #719:
URL: https://github.com/apache/ranger/pull/719#discussion_r2467414064
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
Review Comment:
This may be removed as well.
##########
dev-support/ranger-docker/scripts/access-control.properties:
##########
@@ -0,0 +1,4 @@
+access-control.name=ranger
+
+ranger.service.name=dev_trino
+ranger.plugin.config.resource=/etc/trino/ranger-trino-security.xml,/etc/trino/ranger-trino-audit.xml
Review Comment:
I understand SSL is not enabled in docker yet but can `ranger-policymgr-ssl.xml` be added here as well? Once the support is added, the values would need to updated in that case.
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
-ENV PLUGIN_DIR=ranger-${TRINO_PLUGIN_VERSION}-trino-plugin
-RUN mkdir -p /home/ranger/dist /home/ranger/scripts /opt/ranger
+RUN mkdir -p /home/ranger/scripts/
-COPY ./dist/version /home/ranger/dist
-COPY ./dist/ranger-${TRINO_PLUGIN_VERSION}-trino-plugin.tar.gz /home/ranger/dist
-COPY ./scripts/ranger-trino.sh /home/ranger/scripts
-COPY ./scripts/ranger-trino-setup.sh /home/ranger/scripts
-COPY ./scripts/ranger-trino-plugin-install.properties /home/ranger/scripts
+COPY ./scripts/access-control.properties /etc/trino/
Review Comment:
How about keeping all config files in a `dir` named `trino` inside `scripts` or `configs` and just using
COPY ./configs/trino/* /path/in/trino/container here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5386: Docker setup updated to use latest Trino release [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj merged PR #719:
URL: https://github.com/apache/ranger/pull/719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org