You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/11/29 19:17:58 UTC
[GitHub] [geode] albertogpz opened a new pull request #7147: GEODE-9859: Do not copy entry if it is a destroyed entry
albertogpz opened a new pull request #7147:
URL: https://github.com/apache/geode/pull/7147
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz commented on pull request #7147: GEODE-9859: Do not copy entry if it is a destroyed entry
Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #7147:
URL: https://github.com/apache/geode/pull/7147#issuecomment-1016300104
> A small unit test along with this PR may be needed.
@nabarunnag Are you ok with the unit test added? Any other thing to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz commented on pull request #7147: GEODE-9859: Do not copy entry if it is a destroyed entry
Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #7147:
URL: https://github.com/apache/geode/pull/7147#issuecomment-993779246
> A small unit test along with this PR may be needed.
@nabarunnag Could you please review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz commented on pull request #7147: GEODE-9859: Do not copy entry if it is a destroyed entry
Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #7147:
URL: https://github.com/apache/geode/pull/7147#issuecomment-1022537964
> @albertogpz Any plans of merging this PR. Also there is a new ticket created in the same area GEODE-9984 can you please look into that (and take ticket ownership)
@agingade I would like to merge but I still need the approval from @nabarunnag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7147: GEODE-9859: Do not copy entry if it is a destroyed entry
Posted by GitBox <gi...@apache.org>.
albertogpz merged pull request #7147:
URL: https://github.com/apache/geode/pull/7147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] agingade commented on pull request #7147: GEODE-9859: Do not copy entry if it is a destroyed entry
Posted by GitBox <gi...@apache.org>.
agingade commented on pull request #7147:
URL: https://github.com/apache/geode/pull/7147#issuecomment-1022528244
@albertogpz Any plans of merging this PR. Also there is a new ticket created in the same area GEODE-9984 can you please look into that (and take ticket ownership)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org