You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/25 06:07:05 UTC

[GitHub] [spark] maropu commented on issue #24187: [SPARK-27256][CORE][SQL]If the configuration is used to set the number of bytes, we'd better use `bytesConf`'.

maropu commented on issue #24187: [SPARK-27256][CORE][SQL]If the configuration is used to set the number of bytes, we'd better use `bytesConf`'.
URL: https://github.com/apache/spark/pull/24187#issuecomment-476066511
 
 
   We could have the same fix below, too?
   https://github.com/apache/spark/blob/8ec6cb67c71c67788230cab8a0cd34d8ad3ce24b/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala#L61
   
   Anyway, have you checked all the related places for the same fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org