You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "s4ravanan (via GitHub)" <gi...@apache.org> on 2026/09/21 06:52:49 UTC
[PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
s4ravanan opened a new pull request, #8228:
URL: https://github.com/apache/incubator-seata/pull/8228
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [x] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
- Upgrade MySQL Connector/J to 8.4.0 to resolve CVE-2023-22102.
- Update MySQL 8 driver coordinates from `mysql:mysql-connector-java` to `com.mysql:mysql-connector-j` in `dependencies/pom.xml` and `server/pom.xml`.
- Update `test-suite/seata-benchmark-cli/pom.xml` to inherit managed `com.mysql:mysql-connector-j` version.
- Exclude `com.mysql` group from server root `lib/` to isolate driver into `lib/jdbc/`.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #8101
### Ⅲ. Why don't you add test cases (unit test/integration test)?
This is a dependency version upgrade and Maven configuration update; existing unit and integration tests cover JDBC data sources and driver loading.
### Ⅳ. Describe how to verify it
1. Run `mvn validate` across the reactor.
2. Check effective POM of modules depending on `com.mysql:mysql-connector-j`.
3. Verify driver isolation packaging via `mvn package -pl server -am -Pimage -DskipTests`.
### Ⅴ. Special notes for reviews
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4080711656
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
> Would you like me to go ahead and update the POM files across the repository to remove mysql-connector-java and test the build? @funky-eyes
Yes, because I don't think it's being used anymore, either during the build process or in any of the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#issuecomment-6060203953
> [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:58:30: Name 'testRecordId' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:59:33: Name 'testRecordName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:60:31: Name 'testTid' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:61:33: Name 'mockXid' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new
-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:62:31: Name 'mockBranchId' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:64:33: Name 'pg_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:65:33: Name 'pg_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:66:33: Name 'pg_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:67:33: Name 'pg_d
riverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:69:33: Name 'mysql_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:70:33: Name 'mysql_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:71:33: Name 'mysql_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:72:33: Name 'mysql_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-
9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:74:33: Name 'mysql8_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:76:33: Name 'mysql8_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:77:33: Name 'mysql8_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:78:33: Name 'mysql8_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incub
ator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:80:33: Name 'oracle_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:81:33: Name 'oracle_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:82:33: Name 'oracle_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:83:33: Name 'oracle_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/
src/test/java/org/apache/seata/xa/XAModeTest2.java:86:33: Name 'dbType' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:88:34: Name 'nativeXA' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] [ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:90:34: Name 'mySQL8' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ConstantName] Audit done. [INFO] There are 24 errors reported by Checkstyle 9.3 with style/checkstyle.xml ruleset. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[58,30] (naming) ConstantName: Name 'testRecordId' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[59,33] (naming) ConstantName: Name 'testRecordName' must match pattern '^[A-Z][A-Z0
-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[60,31] (naming) ConstantName: Name 'testTid' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[61,33] (naming) ConstantName: Name 'mockXid' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[62,31] (naming) ConstantName: Name 'mockBranchId' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[64,33] (naming) ConstantName: Name 'pg_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[65,33] (naming) ConstantName: Name 'pg_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[66,33] (naming) ConstantName: Name 'pg_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/j
ava/org/apache/seata/xa/XAModeTest2.java:[67,33] (naming) ConstantName: Name 'pg_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[69,33] (naming) ConstantName: Name 'mysql_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[70,33] (naming) ConstantName: Name 'mysql_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[71,33] (naming) ConstantName: Name 'mysql_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[72,33] (naming) ConstantName: Name 'mysql_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[74,33] (naming) ConstantName: Name 'mysql8_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java
/org/apache/seata/xa/XAModeTest2.java:[76,33] (naming) ConstantName: Name 'mysql8_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[77,33] (naming) ConstantName: Name 'mysql8_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[78,33] (naming) ConstantName: Name 'mysql8_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[80,33] (naming) ConstantName: Name 'oracle_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[81,33] (naming) ConstantName: Name 'oracle_username' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[82,33] (naming) ConstantName: Name 'oracle_password' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/
org/apache/seata/xa/XAModeTest2.java:[83,33] (naming) ConstantName: Name 'oracle_driverClassName' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[86,33] (naming) ConstantName: Name 'dbType' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[88,34] (naming) ConstantName: Name 'nativeXA' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'. [ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[90,34] (naming) ConstantName: Name 'mySQL8' must match pattern '^[A-Z][A-Z0-9]_(_[A-Z0-9]+)_$'.
@funky-eyes i have fixed the reported issues, can you please review and let me know the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4078830381
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
It was kept only to preserve backward-compatibility for MySQL 5.1.x test cases and packaging (lib/jdbc). Since com.mysql:mysql-connector-j (8.4.0) supports MySQL 5.7+ and 8.x, if we want to completely drop mysql:mysql-connector-java, I can remove it and migrate all remaining test/packaging modules to com.mysql:mysql-connector-j.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4078787999
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
Is mysql-connector-java still necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4078904859
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
Would you like me to go ahead and update the POM files across the repository to remove mysql-connector-java and test the build? @funky-eyes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4100445050
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
@funky-eyes please let me know the next steps, the PR is still open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#issuecomment-6053332943
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:58:30: Name 'testRecordId' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:59:33: Name 'testRecordName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:60:31: Name 'testTid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:61:33: Name 'mockXid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:62:31: Name 'mockBranchId' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:64:33: Name 'pg_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:65:33: Name 'pg_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:66:33: Name 'pg_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:67:33: Name 'pg_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:69:33: Name 'mysql_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:70:33: Name 'mysql_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:71:33: Name 'mysql_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:72:33: Name 'mysql_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:74:33: Name 'mysql8_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:76:33: Name 'mysql8_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:77:33: Name 'mysql8_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:78:33: Name 'mysql8_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:80:33: Name 'oracle_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:81:33: Name 'oracle_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:82:33: Name 'oracle_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:83:33: Name 'oracle_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:86:33: Name 'dbType' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:88:34: Name 'nativeXA' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
[ERROR] /home/runner/work/incubator-seata/incubator-seata/test-suite/test-new-version/src/test/java/org/apache/seata/xa/XAModeTest2.java:90:34: Name 'mySQL8' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
Audit done.
[INFO] There are 24 errors reported by Checkstyle 9.3 with style/checkstyle.xml ruleset.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[58,30] (naming) ConstantName: Name 'testRecordId' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[59,33] (naming) ConstantName: Name 'testRecordName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[60,31] (naming) ConstantName: Name 'testTid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[61,33] (naming) ConstantName: Name 'mockXid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[62,31] (naming) ConstantName: Name 'mockBranchId' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[64,33] (naming) ConstantName: Name 'pg_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[65,33] (naming) ConstantName: Name 'pg_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[66,33] (naming) ConstantName: Name 'pg_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[67,33] (naming) ConstantName: Name 'pg_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[69,33] (naming) ConstantName: Name 'mysql_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[70,33] (naming) ConstantName: Name 'mysql_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[71,33] (naming) ConstantName: Name 'mysql_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[72,33] (naming) ConstantName: Name 'mysql_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[74,33] (naming) ConstantName: Name 'mysql8_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[76,33] (naming) ConstantName: Name 'mysql8_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[77,33] (naming) ConstantName: Name 'mysql8_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[78,33] (naming) ConstantName: Name 'mysql8_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[80,33] (naming) ConstantName: Name 'oracle_jdbcUrl' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[81,33] (naming) ConstantName: Name 'oracle_username' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[82,33] (naming) ConstantName: Name 'oracle_password' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[83,33] (naming) ConstantName: Name 'oracle_driverClassName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[86,33] (naming) ConstantName: Name 'dbType' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[88,34] (naming) ConstantName: Name 'nativeXA' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] src/test/java/org/apache/seata/xa/XAModeTest2.java:[90,34] (naming) ConstantName: Name 'mySQL8' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4089490199
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
Done. Deprecated \mysql:mysql-connector-java\ and associated legacy properties have been completely removed across repository POMs, and test dependencies and mock configurations have been modernized to \com.mysql:mysql-connector-j\ (8.4.0). Rebased with latest 2.x and verified all builds and tests pass cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on code in PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#discussion_r4119155703
##########
dependencies/pom.xml:
##########
@@ -305,6 +305,11 @@
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.mysql</groupId>
Review Comment:
@funky-eyes I have addressed the changes as requested. Please let me know the next steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "s4ravanan (via GitHub)" <gi...@apache.org>.
s4ravanan commented on PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#issuecomment-5770361915
@funky-eyes can you please review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#issuecomment-6093351754
[ERROR] XAModeTest2.java:[471,42] cannot find symbol
symbol: variable mockXid
[ERROR] XAModeTest2.java:[471,51] cannot find symbol
symbol: variable mockBranchId
[ERROR] XAModeTest2.java:[477,33] cannot find symbol
symbol: variable mockXid
[ERROR] XAModeTest2.java:[478,33] cannot find symbol
symbol: variable mockBranchId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] security: upgrade mysql connector to 8.4.0 to fix CVE-2023-22102 [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8228:
URL: https://github.com/apache/incubator-seata/pull/8228#issuecomment-5756784515
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8228?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.35%. Comparing base ([`41694e1`](https://app.codecov.io/gh/apache/incubator-seata/commit/41694e140b40894aa3aae4cfe6ecffed9b321a36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a880c52`](https://app.codecov.io/gh/apache/incubator-seata/commit/a880c52b6925495bbd1a8eeb0455fb17d6ffafb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8228 +/- ##
============================================
+ Coverage 73.22% 73.35% +0.12%
Complexity 1146 1146
============================================
Files 1153 1153
Lines 42348 42348
Branches 5061 5061
============================================
+ Hits 31011 31065 +54
+ Misses 8852 8806 -46
+ Partials 2485 2477 -8
```
[see 22 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org