You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/22 21:32:58 UTC

[GitHub] [tvm] michalpiszczek opened a new pull request, #12546: Remove mutable defaults in mlp_model

michalpiszczek opened a new pull request, #12546:
URL: https://github.com/apache/tvm/pull/12546

   Removes [mutable default arguments](https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments) in `python/tvm/meta_schedule/cost_model/mlp_model.py`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Kathryn-cat commented on pull request #12546: Remove mutable default arguments in mlp_model

Posted by GitBox <gi...@apache.org>.
Kathryn-cat commented on PR #12546:
URL: https://github.com/apache/tvm/pull/12546#issuecomment-1223333038

   LGTM!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] michalpiszczek commented on pull request #12546: Remove mutable default arguments in mlp_model

Posted by GitBox <gi...@apache.org>.
michalpiszczek commented on PR #12546:
URL: https://github.com/apache/tvm/pull/12546#issuecomment-1223352639

   Thank you for the reviews @junrushao @Kathryn-cat !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] michalpiszczek commented on pull request #12546: Remove mutable default arguments in mlp_model

Posted by GitBox <gi...@apache.org>.
michalpiszczek commented on PR #12546:
URL: https://github.com/apache/tvm/pull/12546#issuecomment-1223116485

   cc @zxybazh @Kathryn-cat PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] zxybazh merged pull request #12546: Remove mutable default arguments in mlp_model

Posted by GitBox <gi...@apache.org>.
zxybazh merged PR #12546:
URL: https://github.com/apache/tvm/pull/12546


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org