[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #758: feat(c/driver/postgresql): add timestamp types support

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #758:
URL: https://github.com/apache/arrow-adbc/pull/758#discussion_r1224829540


##########
c/driver/postgresql/postgres_type.h:
##########
@@ -223,6 +223,14 @@ class PostgresType {
         NANOARROW_RETURN_NOT_OK(ArrowSchemaSetType(schema, NANOARROW_TYPE_BINARY));
         break;
 
+      case PostgresTypeId::kTimestamp:
+        // TODO: it's possible to set a precision in the type, but how do we get that

Review Comment:
   Ah, thanks.
   
   Yeah, when I was checking the type mapping for Postgres on the Java side I decided to make it vary based on the specified precision, but just always using microsecond would be easiest, so I'll fix up the Java side after this.
   
   That said we probably do need to figure this out for TIMESTAMPTZ and eventually things like decimals.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org