[GitHub] [apisix] gxthrj commented on a change in pull request #2322: bugfix: when service works with upstream that contains a domain name, the merged configuration should not always changing.

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #2322:
URL: https://github.com/apache/apisix/pull/2322#discussion_r495362588



##########
File path: apisix/init.lua
##########
@@ -461,23 +455,15 @@ function _M.http_access_phase()
 
     else
         if route.has_domain then
-            local parsed_route, err = lru_resolved_domain(route, api_ctx.conf_version,
-                                        return_direct, nil)
+            local err
+            route, err = lru_resolved_domain(route, api_ctx.conf_version,
+                            parse_domain_in_route, route, api_ctx)

Review comment:
       `api_ctx` need to be removed ？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org