You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vladimir Ozerov (JIRA)" <ji...@apache.org> on 2019/02/14 15:27:00 UTC

[jira] [Resolved] (IGNITE-6318) SQL: Make sure that QueryTypeDescriptorImpl is used in thread-safe manner

     [ https://issues.apache.org/jira/browse/IGNITE-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ozerov resolved IGNITE-6318.
-------------------------------------
    Resolution: Won't Fix

Not relevant at the moment. Will reopen if needed.

> SQL: Make sure that QueryTypeDescriptorImpl is used in thread-safe manner
> -------------------------------------------------------------------------
>
>                 Key: IGNITE-6318
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6318
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>    Affects Versions: 2.3
>            Reporter: Vladimir Ozerov
>            Priority: Major
>
> {{QueryTypeDescriptorImpl}} is mostly immutable structure. But as we add more and more DDL features, it becomes mutable. We need to make sure that it is still thread-safe.
> Specifically, when {{CREATE INDEX}} command was implemented, I guarded index collection with mutex. Now we added {{ALTER TABLE}} command, and it seems that thread-safety for columns was lost. 
> I propose to re-use index mutex (rename it to {{stateMux}}) and make sure that column collections are also thread-safe. I would also propose to consider copy-on-write approach, as these collections are returned by some methods as is.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)