You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/10/26 10:15:07 UTC

[PR] fix: tapd story changelog connecting to record from another connection [incubator-devlake]

klesh opened a new pull request, #6342:
URL: https://github.com/apache/incubator-devlake/pull/6342

   ### Summary
   
   The cause: The SQL in the `story_changelog_convertor` fails to join tables with the same `connection_id`
   The solution: 
   - added a helper function to copy and change some of the fields to mimic the situation described in #6336 
   - updated the e2e test case to cover the bug
   
   
   ### Does this close any open issues?
   Closes #6336
   
   ### Screenshots
   Before the fix, the updated e2e case would fail:
   <img width="647" alt="Snipaste_2023-10-26_17-28-13" src="https://github.com/apache/incubator-devlake/assets/61080/f5f0d393-68af-4cf3-9364-dc2008c2264c">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: tapd story changelog connecting to record from another connection [incubator-devlake]

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #6342:
URL: https://github.com/apache/incubator-devlake/pull/6342


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: tapd story changelog connecting to record from another connection [incubator-devlake]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6342:
URL: https://github.com/apache/incubator-devlake/pull/6342#issuecomment-1780974607

   🤖 cherry pick finished successfully 🎉!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org