You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/16 20:49:57 UTC

[GitHub] [beam] reuvenlax commented on a change in pull request #15184: [BEAM-12589] - exclude testTwoTimersSettingEachOtherWithCreateAsInput…

reuvenlax commented on a change in pull request #15184:
URL: https://github.com/apache/beam/pull/15184#discussion_r671518065



##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -319,7 +321,6 @@ task validatesRunnerStreaming {
       'org.apache.beam.sdk.testing.UsesMapState',
       'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
       'org.apache.beam.sdk.testing.UsesSetState',
-      'org.apache.beam.sdk.testing.UsesStrictTimerOrdering',
     ],

Review comment:
       I think this is fine since this inherits from the other tuple, but please double check that this test remains excluded from streaming even after removing this line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org