You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pgaref (via GitHub)" <gi...@apache.org> on 2023/05/26 04:34:58 UTC

[GitHub] [flink] pgaref opened a new pull request, #22663: [FLINK-32198][runtime] Enforce single maxExceptions query parameter

pgaref opened a new pull request, #22663:
URL: https://github.com/apache/flink/pull/22663

   https://issues.apache.org/jira/browse/FLINK-32198
   
   * throw ConversionException when multiple values are passed for maxExceptions parameter
   * added test to validate functionality


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol commented on pull request #22663: [FLINK-32198][runtime] Enforce single maxExceptions query parameter

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #22663:
URL: https://github.com/apache/flink/pull/22663#issuecomment-1568020468

   > Whats the policy for making such changes?
   
   The policy is that we can't make the change until Flink 2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22663: [FLINK-32198][runtime] Enforce single maxExceptions query parameter

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22663:
URL: https://github.com/apache/flink/pull/22663#issuecomment-1563798860

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3d10cec1ba099543e8ae4ceef670caae9f145553",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3d10cec1ba099543e8ae4ceef670caae9f145553",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3d10cec1ba099543e8ae4ceef670caae9f145553 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-32198][runtime] Enforce single maxExceptions query parameter [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #22663: [FLINK-32198][runtime] Enforce single maxExceptions query parameter
URL: https://github.com/apache/flink/pull/22663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-32198][runtime] Enforce single maxExceptions query parameter [flink]

Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #22663:
URL: https://github.com/apache/flink/pull/22663#issuecomment-1844115554

   Hey @zentol  -- are we currently allowing changes as part of Flink 2.0? Would it make sense pushing this fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-32198][runtime] Enforce single maxExceptions query parameter [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22663:
URL: https://github.com/apache/flink/pull/22663#issuecomment-2595358225

   This PR is being marked as stale since it has not had any activity in the last 180 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 90 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-32198][runtime] Enforce single maxExceptions query parameter [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22663:
URL: https://github.com/apache/flink/pull/22663#issuecomment-2774618272

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] pgaref commented on pull request #22663: [FLINK-32198][runtime] Enforce single maxExceptions query parameter

Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #22663:
URL: https://github.com/apache/flink/pull/22663#issuecomment-1564774191

   > This is an api-breaking change and can't be merged.
   
   Thanks for taking a look @zentol !
   What the policy for making breaking changes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org