You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by fcav1973 <gi...@git.apache.org> on 2017/10/11 08:17:21 UTC
[GitHub] mina-sshd pull request #38: [SSHD-776] SSHD local port forwarding close sess...
GitHub user fcav1973 opened a pull request:
https://github.com/apache/mina-sshd/pull/38
[SSHD-776] SSHD local port forwarding close session unexpectedly
This patch contains the following modifications:
1. _AbstractConnectionService.channelWindowAdjust_: we did the same modifications as for channelEof; checking RFC there is the same level of ambiguity
2. _Nio2Session.exceptionCaught_: the session should be any closed (the close method is already resilient to subsequent calls). This was necessay because we found some messages in write queue afer the exception management.
3. _TcpipServerChannel.close_: this have been changed to let the connector to close immediatly os gracefully, accordingly to the way the API is called. Most of the problem we have found where related write messages still pending during a gracefull close
4. _TcpipServerChannel.handleWriteDataFailure_: this have been necessary because in case the remote server had closed the connection, some data could be still waiting in the channel to be written to the outgoing session (even if channel close have been already sent) that could be already closed. In that case we should simply have to discard those error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fcav1973/mina-sshd master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 767f2772de040504b53b05e07ef713453a534772
Author: cu0132 <fu...@primeur.com>
Date: 2017-10-11T08:10:42Z
https://issues.apache.org/jira/browse/SSHD-776
commit ad67d269d982e0144d085bd08e50cf778cf68e96
Author: cu0132 <fu...@primeur.com>
Date: 2017-10-11T08:11:01Z
https://issues.apache.org/jira/browse/SSHD-776
----
---
[GitHub] mina-sshd pull request #38: [SSHD-776] SSHD local port forwarding close sess...
Posted by fcav1973 <gi...@git.apache.org>.
Github user fcav1973 closed the pull request at:
https://github.com/apache/mina-sshd/pull/38
---