[GitHub] [accumulo] ctubbsii commented on a change in pull request #1450: Fix #1373 Support the init scope in some VolumeChoosers

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1450: Fix #1373 Support the init scope in some VolumeChoosers
URL: https://github.com/apache/accumulo/pull/1450#discussion_r355720444
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
 ##########
 @@ -362,7 +361,7 @@ private boolean initialize(SiteConfiguration siteConfig, Configuration hadoopCon
     UUID uuid = UUID.randomUUID();
     // the actual disk locations of the root table and tablets
     String[] configuredVolumes = VolumeConfiguration.getVolumeUris(siteConfig, hadoopConf);
-    VolumeChooserEnvironment chooserEnv = new VolumeChooserEnvironmentImpl(ChooserScope.INIT, null);
+    VolumeChooserEnvironment chooserEnv = new InitVolumeChooserEnvironmentImpl(siteConfig);
 
 Review comment:
   The INIT scope is for all initial tables during the INIT phase... since those tables can't be individually configured in ZK yet and our config isn't expressive enough to distinguish between the different tables whose initial files are created during INIT. So, I never thought a chooser would be able to (or care to) make different choices for different tables during INIT. However, I wasn't thinking about the possibility of having a chooser make hard-coded decisions, or use some external configuration system (Java system props or ENV variables). So, I agree that adding table information to the VolumeChooserEnvironment may be useful as follow-on work to support some chooser implementations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services