You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Adam Clarke <cl...@gmail.com> on 2012/06/19 14:56:47 UTC
Review Request: Code Review for JIRA 1793,
expose OAuth2 client invalidation on OAuth2Store
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5419/
-----------------------------------------------------------
Review request for shindig, Stanton Sievers, Brian Lillie, and Doug Davies.
Description
-------
This fix exposes the ability to invalidate a Client on the OAuth2Store interface. It allows client management applications the ability to clear clients from the cache without having to get the cache instance itself.
This addresses bug SHINDIG-1793.
https://issues.apache.org/jira/browse/SHINDIG-1793
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1346021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1346021
Diff: https://reviews.apache.org/r/5419/diff/
Testing
-------
All unit tests pass
Thanks,
Adam Clarke
Re: Review Request: Code Review for JIRA 1793,
expose OAuth2 client invalidation on OAuth2Store
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5419/#review8388
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On June 19, 2012, 1:09 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5419/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:09 p.m.)
>
>
> Review request for shindig, Stanton Sievers, Brian Lillie, and Doug Davies.
>
>
> Description
> -------
>
> This fix exposes the ability to invalidate a Client on the OAuth2Store interface. It allows client management applications the ability to clear clients from the cache without having to get the cache instance itself.
>
>
> This addresses bug SHINDIG-1793.
> https://issues.apache.org/jira/browse/SHINDIG-1793
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1351689
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1351689
>
> Diff: https://reviews.apache.org/r/5419/diff/
>
>
> Testing
> -------
>
> All unit tests pass
>
>
> Thanks,
>
> Adam Clarke
>
>
Re: Review Request: Code Review for JIRA 1793,
expose OAuth2 client invalidation on OAuth2Store
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5419/#review8389
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On June 19, 2012, 1:09 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5419/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:09 p.m.)
>
>
> Review request for shindig, Stanton Sievers, Brian Lillie, and Doug Davies.
>
>
> Description
> -------
>
> This fix exposes the ability to invalidate a Client on the OAuth2Store interface. It allows client management applications the ability to clear clients from the cache without having to get the cache instance itself.
>
>
> This addresses bug SHINDIG-1793.
> https://issues.apache.org/jira/browse/SHINDIG-1793
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1351689
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1351689
>
> Diff: https://reviews.apache.org/r/5419/diff/
>
>
> Testing
> -------
>
> All unit tests pass
>
>
> Thanks,
>
> Adam Clarke
>
>
Re: Review Request: Code Review for JIRA 1793,
expose OAuth2 client invalidation on OAuth2Store
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5419/#review8436
-----------------------------------------------------------
Ship it!
Committed revision 1352375.
- Ryan Baxter
On June 19, 2012, 1:09 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5419/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:09 p.m.)
>
>
> Review request for shindig, sieverssj_do_not_use, Brian Lillie, and Doug Davies.
>
>
> Description
> -------
>
> This fix exposes the ability to invalidate a Client on the OAuth2Store interface. It allows client management applications the ability to clear clients from the cache without having to get the cache instance itself.
>
>
> This addresses bug SHINDIG-1793.
> https://issues.apache.org/jira/browse/SHINDIG-1793
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1351689
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1351689
>
> Diff: https://reviews.apache.org/r/5419/diff/
>
>
> Testing
> -------
>
> All unit tests pass
>
>
> Thanks,
>
> Adam Clarke
>
>
Re: Review Request: Code Review for JIRA 1793,
expose OAuth2 client invalidation on OAuth2Store
Posted by Doug Davies <da...@oclc.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5419/#review8393
-----------------------------------------------------------
Ship it!
Ship It!
- Doug Davies
On June 19, 2012, 1:09 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5419/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:09 p.m.)
>
>
> Review request for shindig, Stanton Sievers, Brian Lillie, and Doug Davies.
>
>
> Description
> -------
>
> This fix exposes the ability to invalidate a Client on the OAuth2Store interface. It allows client management applications the ability to clear clients from the cache without having to get the cache instance itself.
>
>
> This addresses bug SHINDIG-1793.
> https://issues.apache.org/jira/browse/SHINDIG-1793
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1351689
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1351689
>
> Diff: https://reviews.apache.org/r/5419/diff/
>
>
> Testing
> -------
>
> All unit tests pass
>
>
> Thanks,
>
> Adam Clarke
>
>
Re: Review Request: Code Review for JIRA 1793,
expose OAuth2 client invalidation on OAuth2Store
Posted by Adam Clarke <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5419/
-----------------------------------------------------------
(Updated June 19, 2012, 1:09 p.m.)
Review request for shindig, Stanton Sievers, Brian Lillie, and Doug Davies.
Changes
-------
Ran diff against latest trunk and fixed whitespace issues.
Description
-------
This fix exposes the ability to invalidate a Client on the OAuth2Store interface. It allows client management applications the ability to clear clients from the cache without having to get the cache instance itself.
This addresses bug SHINDIG-1793.
https://issues.apache.org/jira/browse/SHINDIG-1793
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1351689
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1351689
Diff: https://reviews.apache.org/r/5419/diff/
Testing
-------
All unit tests pass
Thanks,
Adam Clarke