You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/12/05 15:01:45 UTC

[GitHub] [nifi] ChrisSamo632 commented on a change in pull request #5518: NIFI-9333 add Geohash functions to Expression Language

ChrisSamo632 commented on a change in pull request #5518:
URL: https://github.com/apache/nifi/pull/5518#discussion_r762574178



##########
File path: nifi-commons/nifi-expression-language/pom.xml
##########
@@ -108,5 +108,10 @@
             <artifactId>commons-codec</artifactId>
             <version>1.14</version>
         </dependency>
+        <dependency>
+            <groupId>ch.hsr</groupId>
+            <artifactId>geohash</artifactId>
+            <version>1.4.0</version>

Review comment:
       Version 1.5.0 now available, should we use that?
   
   Also, it's Apache 2.0 licensed (great), but presumably we need to update our LICENSE/NOTICE files to reflect the fact we're using the library?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org