You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/15 23:31:00 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
nealrichardson opened a new pull request #9209:
URL: https://github.com/apache/arrow/pull/9209
Key features:
* if arrowExports.* are not modified, they are not rewritten. This means that if there are no cpp changes, then nothing gets recompiled, which makes local dev faster (when you have ARROW_R_DEV=true set)
* refactoring of codegen.R to be more consistently aware of "features" that can be flagged, like we have currently for `arrow` and `s3` and potentially may get more of in the future with additional build-time features. Importantly, the wrapping with the fake implementation that we currently have for all functions has been encapsulated in such a way that we can choose whether to make some features always on or not.
At this point, this PR is purely a refactor, but by uncommenting an `if` statement, we can effectively remove the arrow-without-arrow wrapping while still keeping S3 support optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson removed a comment on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
nealrichardson removed a comment on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-763212980
@benchmark me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-763212980
@benchmark me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson removed a comment on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
ElenaHenderson removed a comment on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-763214267
test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-761253734
https://issues.apache.org/jira/browse/ARROW-10735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-767863067
I've made ARROW-11392 for the final removal of the arrow-without-arrow flagging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-767860365
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9209:
URL: https://github.com/apache/arrow/pull/9209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on pull request #9209: ARROW-10735: [R] Remove arrow-without-arrow wrapping
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on pull request #9209:
URL: https://github.com/apache/arrow/pull/9209#issuecomment-763214267
test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org