You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/08/28 21:43:44 UTC
[jira] Created: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
test coverage on async client operations needs to be improved
-------------------------------------------------------------
Key: ZOOKEEPER-128
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
Project: Zookeeper
Issue Type: Improvement
Components: java client
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Attachments: ZOOKEEPER-128.patch
clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628957#action_12628957 ]
Hudson commented on ZOOKEEPER-128:
----------------------------------
Integrated in ZooKeeper-trunk #76 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/76/])
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-128.patch, ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-128:
-----------------------------------
Fix Version/s: 3.0.0
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-128:
-----------------------------------
Status: Patch Available (was: Open)
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Attachments: ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628358#action_12628358 ]
Benjamin Reed commented on ZOOKEEPER-128:
-----------------------------------------
I'm trying to review this, but I'm getting really lost in the virtual functions. I'm trying to follow the code, but it would help to explain the format of the expected and actual strings and how they are generated. Perhaps walking through delete as an example.
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-128:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 692527.
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-128.patch, ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-128:
-----------------------------------
Attachment: ZOOKEEPER-128.patch
some basic async operations tests
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Attachments: ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client
operations needs to be improved
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-128:
-----------------------------------
Attachment: ZOOKEEPER-128.patch
Updated the patch to include more documentation. I didn't document the exact format of each subclasses expect string (tostring output) since it's really easy to determine by looking at the toString method, but I did document more about how the expected value is generated and pointed out that it's the result of toString.
> test coverage on async client operations needs to be improved
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-128
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-128.patch, ZOOKEEPER-128.patch
>
>
> clover reports limited testing of the async client operations. need addition tests to verify this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.