[jira] [Commented] (MNG-7717) Maven warns wrongly about ${localRepository} expression

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696053#comment-17696053 ] 

ASF GitHub Bot commented on MNG-7717:
-------------------------------------

cstamas opened a new pull request, #1031:
URL: https://github.com/apache/maven/pull/1031

   The implementation for MNG-7706 is wrong: it changes parameter NAME, where it should check type and defaultValue instead.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7717




> Maven warns wrongly about ${localRepository} expression
> -------------------------------------------------------
>
>                 Key: MNG-7717
>                 URL: https://issues.apache.org/jira/browse/MNG-7717
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is represented by {{ArtifactRepository}} legacy type. But the code is too eager, it warns about {{settings.localRepository}} expression as well, while it does NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check for *type* and *defaultValue* expression.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)