You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2019/08/06 23:54:48 UTC
[GitHub] [hive] jcamachor commented on a change in pull request #746:
HIVE-22074: Slow compilation due to IN to OR transformation
jcamachor commented on a change in pull request #746: HIVE-22074: Slow compilation due to IN to OR transformation
URL: https://github.com/apache/hive/pull/746#discussion_r311318637
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
##########
@@ -151,13 +153,15 @@ public RexNodeConverter(RelOptCluster cluster) {
//subqueries will need outer query's row resolver
public RexNodeConverter(RelOptCluster cluster, RelDataType inpDataType,
ImmutableMap<String, Integer> outerNameToPosMap,
- ImmutableMap<String, Integer> nameToPosMap, RowResolver hiveRR, RowResolver outerRR, int offset, boolean flattenExpr, int correlatedId) {
+ ImmutableMap<String, Integer> nameToPosMap, RowResolver hiveRR, RowResolver outerRR,
+ HiveConf conf, int offset, boolean flattenExpr, int correlatedId) {
Review comment:
Can we pass the int value instead of the full config object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org