You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/05/28 00:32:12 UTC
[kudu-CR] consensus: Acquire lock before snoozing FD
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7010
to review the following change.
Change subject: consensus: Acquire lock before snoozing FD
......................................................................
consensus: Acquire lock before snoozing FD
We should only call SnoozeFailureDetectorUnlocked() while holding the
state lock. This was caught in an unrelated change after adding a DCHECK
to SnoozeFailureDetectorUnlocked().
Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/7010/1
--
To view, visit http://gerrit.cloudera.org:8080/7010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] consensus: Acquire lock before snoozing FD
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: consensus: Acquire lock before snoozing FD
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7010/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
PS1, Line 1328: SnoozeFailureDetectorUnlocked
do you think it makes sense to add an assertion into the SnoozeFailureDetectorUnlocked(), like
DCHECK(state_->update_lock_.is_locked());
?
--
To view, visit http://gerrit.cloudera.org:8080/7010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] consensus: Acquire lock before snoozing FD
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: consensus: Acquire lock before snoozing FD
......................................................................
Patch Set 1: Code-Review+2
Oh, I see you added those DCHECKS() for the locks in all XxxUnlocked() methods in a separate changelist.
--
To view, visit http://gerrit.cloudera.org:8080/7010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] consensus: Acquire lock before snoozing FD
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: consensus: Acquire lock before snoozing FD
......................................................................
consensus: Acquire lock before snoozing FD
We should only call SnoozeFailureDetectorUnlocked() while holding the
state lock. This was caught in an unrelated change after adding a DCHECK
to SnoozeFailureDetectorUnlocked().
Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
Reviewed-on: http://gerrit.cloudera.org:8080/7010
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] consensus: Acquire lock before snoozing FD
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: consensus: Acquire lock before snoozing FD
......................................................................
Patch Set 1:
> Oh, I see you added those DCHECKS() for the locks in all
> XxxUnlocked() methods in a separate changelist.
Yes, exactly. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/7010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No