You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/09/01 01:56:33 UTC

Review Request 62023: RANGER-1735: Support representing nested group memberships in Ranger Admin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62023/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.

Bugs: RANGER-1735
https://issues.apache.org/jira/browse/RANGER-1735

Repository: ranger

Description
-------

Initial implementation of evaluating nested group memberships for Ranger usersyc based on the design mentioned in the apache jira. Modified test ldif file to include nested groups, updated test config file to enable the nested group evaluation, and modified few unit tests to cover the new logic.

Diffs
-----

ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java d27a217
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java e62da5b
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java af27efa
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java 6ebc311
ugsync/src/test/resources/ADSchema.ldif a45a2fb
ugsync/src/test/resources/ranger-ugsync-site.xml 7d1c27c

Diff: https://reviews.apache.org/r/62023/diff/1/

Testing
-------

1. Tested new functionality with AD server containing few nested groups
2. Tested for both full sync and delta sync implementations
3. Performed basic regression testing
4. Successfully ran all the related unit tests.

Thanks,

Sailaja Polavarapu

Re: Review Request 62023: RANGER-1735: Support representing nested group memberships in Ranger Admin

Posted by bhavik patel <bh...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62023/#review184350
-----------------------------------------------------------




ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
Lines 976 (patched)
<https://reviews.apache.org/r/62023/#comment260482>

    One minor suggestion : Exception is not thrown within the try block and RuntimeException is not explicitly caught. It will be better to explicitly catch RuntimeException as well.



ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
Lines 884 (patched)
<https://reviews.apache.org/r/62023/#comment260483>

    Same minor suggestion : Exception is not thrown within the try block and RuntimeException is not explicitly caught. It will be better to explicitly catch RuntimeException as well.


- bhavik patel


On Sept. 1, 2017, 1:56 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62023/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 1:56 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1735
>     https://issues.apache.org/jira/browse/RANGER-1735
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Initial implementation of evaluating nested group memberships for Ranger usersyc based on the design mentioned in the apache jira. Modified test ldif file to include nested groups, updated test config file to enable the nested group evaluation, and modified few unit tests to cover the new logic.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java d27a217 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java e62da5b 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java af27efa 
>   ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java 6ebc311 
>   ugsync/src/test/resources/ADSchema.ldif a45a2fb 
>   ugsync/src/test/resources/ranger-ugsync-site.xml 7d1c27c 
> 
> 
> Diff: https://reviews.apache.org/r/62023/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Tested new functionality with AD server containing few nested groups
> 2. Tested for both full sync and delta sync implementations
> 3. Performed basic regression testing
> 4. Successfully ran all the related unit tests.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Re: Review Request 62023: RANGER-1735: Support representing nested group memberships in Ranger Admin

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62023/#review184867
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 7, 2017, 7:25 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62023/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 7:25 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1735
>     https://issues.apache.org/jira/browse/RANGER-1735
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Initial implementation of evaluating nested group memberships for Ranger usersyc based on the design mentioned in the apache jira. Modified test ldif file to include nested groups, updated test config file to enable the nested group evaluation, and modified few unit tests to cover the new logic.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java d27a217 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java e62da5b 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java af27efa 
>   ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java 6ebc311 
>   ugsync/src/test/resources/ADSchema.ldif a45a2fb 
>   ugsync/src/test/resources/ranger-ugsync-site.xml 7d1c27c 
> 
> 
> Diff: https://reviews.apache.org/r/62023/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Tested new functionality with AD server containing few nested groups
> 2. Tested for both full sync and delta sync implementations
> 3. Performed basic regression testing
> 4. Successfully ran all the related unit tests.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Re: Review Request 62023: RANGER-1735: Support representing nested group memberships in Ranger Admin

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.

(Updated Sept. 7, 2017, 7:25 a.m.)

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.

Changes
-------

incorporated review comments and fixed few issues found during testing

Bugs: RANGER-1735
https://issues.apache.org/jira/browse/RANGER-1735

Repository: ranger

Description
-------

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/62023/diff/2/

Changes: https://reviews.apache.org/r/62023/diff/1-2/

Testing
-------

Thanks,

Sailaja Polavarapu