You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/07/12 04:01:34 UTC
Review Request 12493: Short term hack for getting post-reviews.py to work.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12493/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ross Allen, and Vinod Kone.
Repository: mesos
Description
-------
While we're waiting on the infrastructure guys to add the new git repository to Review Board (https://issues.apache.org/jira/browse/INFRA-6547), this is a "hack" for using post-reviews.py. Before using this, however, you'll need to do:
$ git remote add incubator-mesos https://github.com/apache/incubator-mesos.git
$ git fetch incubator-mesos
Once we get Review Board switched over we can remove this.
Diffs
-----
support/post-reviews.py 4099d2c2d00ef2e8fac5369153329dd3de0998c1
Diff: https://reviews.apache.org/r/12493/diff/
Testing
-------
I ran post-reviews with some commits that were previously failing and they now work!
Thanks,
Benjamin Hindman
Re: Review Request 12493: Short term hack for getting post-reviews.py to
work.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 12, 2013, 2:19 a.m., Ben Mahler wrote:
> > Thanks for the workaround, I hope we don't forget to revert this (maybe a ticket or TODO?).
Great idea: https://issues.apache.org/jira/browse/MESOS-545.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12493/#review23054
-----------------------------------------------------------
On July 12, 2013, 2:01 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12493/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 2:01 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ross Allen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While we're waiting on the infrastructure guys to add the new git repository to Review Board (https://issues.apache.org/jira/browse/INFRA-6547), this is a "hack" for using post-reviews.py. Before using this, however, you'll need to do:
>
> $ git remote add incubator-mesos https://github.com/apache/incubator-mesos.git
> $ git fetch incubator-mesos
>
> Once we get Review Board switched over we can remove this.
>
>
> Diffs
> -----
>
> support/post-reviews.py 4099d2c2d00ef2e8fac5369153329dd3de0998c1
>
> Diff: https://reviews.apache.org/r/12493/diff/
>
>
> Testing
> -------
>
> I ran post-reviews with some commits that were previously failing and they now work!
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 12493: Short term hack for getting post-reviews.py to
work.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12493/#review23054
-----------------------------------------------------------
Ship it!
Thanks for the workaround, I hope we don't forget to revert this (maybe a ticket or TODO?).
- Ben Mahler
On July 12, 2013, 2:01 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12493/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 2:01 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ross Allen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While we're waiting on the infrastructure guys to add the new git repository to Review Board (https://issues.apache.org/jira/browse/INFRA-6547), this is a "hack" for using post-reviews.py. Before using this, however, you'll need to do:
>
> $ git remote add incubator-mesos https://github.com/apache/incubator-mesos.git
> $ git fetch incubator-mesos
>
> Once we get Review Board switched over we can remove this.
>
>
> Diffs
> -----
>
> support/post-reviews.py 4099d2c2d00ef2e8fac5369153329dd3de0998c1
>
> Diff: https://reviews.apache.org/r/12493/diff/
>
>
> Testing
> -------
>
> I ran post-reviews with some commits that were previously failing and they now work!
>
>
> Thanks,
>
> Benjamin Hindman
>
>