[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

["Chris Bannister (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124955#comment-16124955 ] 

Chris Bannister commented on THRIFT-4285:
-----------------------------------------

This is a breaking change for the generated code as the methods NewXXXClientFactory no long exist, instead the NewXXXClient takes a TClient which can be customised with different protocol/transport options.

> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4285
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4285
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler, Go - Library
>            Reporter: Chris Bannister
>            Assignee: Chris Bannister
>         Attachments: 0001-go-pull-generated-send-recv-into-lib.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the transport because they are in the generated code. Instead the generated send/recv methods should be in the library. This will greatly simplify the client code and remove many duplicate methods whilst allowing users more flexibility to implement connection pools and other features such as THeader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)