[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction

[GitBox <gi...@apache.org>]

nbauma109 commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045236781


##########
src/test/java/org/apache/bcel/data/SWAP.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.data;
+
+import java.lang.reflect.Constructor;
+
+/*
+ * A test for SWAP instruction.
+ * To be compiled with Eclipse Compiler (ecj) with source/target 1.4.

Review Comment:
   It's indeed a possibility, but I'm not a fan of committing a class file in a repo, if we update the source, the class also needs to be updated and committed too, and also when there's a class file in a repo, one always wonders where it comes from, how it was generated, if it actually matches the source code, or if it can be trusted. If pulling a dependency is more of a problem, I can commit the class instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org