You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Boyles (Jira)" <ji...@apache.org> on 2020/10/06 14:32:00 UTC

[jira] [Commented] (MSTAGE-26) Fix and un-ignore RepositoryCopierTest

    [ https://issues.apache.org/jira/browse/MSTAGE-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208799#comment-17208799 ] 

Michael Boyles commented on MSTAGE-26:
--------------------------------------

Works on my machine™. Had to introduce an FTP server to the test. You can't rely on file:// working consistently cross-platform to "upload" files, much less exec scripts.

Discovered undocumented behaviour that this plugin relies on publishing to a unix system, so had to fake some stuff to get this to run on a Windows machine. Luckily, sshd makes it easy.

Line coverage of the copier is 86%. If you want more in-depth, here:  [^jacoco.zip]

> Fix and un-ignore RepositoryCopierTest
> --------------------------------------
>
>                 Key: MSTAGE-26
>                 URL: https://issues.apache.org/jira/browse/MSTAGE-26
>             Project: Maven Stage Plugin
>          Issue Type: Task
>    Affects Versions: 1.0
>            Reporter: Michael Boyles
>            Priority: Major
>         Attachments: jacoco.zip
>
>
> Stage plugin only has 1 test and it's ignored. The comment next to it says
> "This test fails in various ways on different platforms - from hanging permanently to erroring out. Temporarily exclude it."
> We should fix this test so that it's cross-platform and remove it from the list of ignored tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)