You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/16 07:52:05 UTC

[GitHub] [pulsar] shiv4289 opened a new pull request #4284: [Issue 4283][flink] construct auth when building pulsarsource

shiv4289 opened a new pull request #4284: [Issue 4283][flink] construct auth when building pulsarsource
URL: https://github.com/apache/pulsar/pull/4284
 
 
   <--
   ### Contribution Checklist
    
   Fixes #4283
   
   ### Motivation
   
   pulsar flink connector now uses ClientConfigData to instantiate pulsar client. Pulsar client composes Authentication which can not be serialized. In an environment with Auth there is no way to set auth in pulsar client.
   
   ### Modifications
   
   Keep auth params away from persistence and serialization. Construct auth when building pulsar source
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API: (yes)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no )
   
   ### Documentation
   NA
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services