You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dlab.apache.org by GitBox <gi...@apache.org> on 2020/07/02 15:44:19 UTC
[GitHub] [incubator-dlab] ppapou opened a new pull request #808: [DLAB-1720] Minor fix for exploratory report
ppapou opened a new pull request #808:
URL: https://github.com/apache/incubator-dlab/pull/808
Cost is scaling for WEB UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #808: [DLAB-1720] Minor fix for exploratory report
Posted by GitBox <gi...@apache.org>.
ofuks merged pull request #808:
URL: https://github.com/apache/incubator-dlab/pull/808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #808: [DLAB-1720] Minor fix for exploratory report
Posted by GitBox <gi...@apache.org>.
ppapou commented on a change in pull request #808:
URL: https://github.com/apache/incubator-dlab/pull/808#discussion_r449152948
##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/BillingServiceImpl.java
##########
@@ -140,8 +140,13 @@ public String downloadReport(UserInfo user, BillingFilter filter) {
public BillingReport getExploratoryBillingData(String project, String endpoint, String exploratoryName, List<String> compNames) {
List<String> resourceNames = new ArrayList<>(compNames);
resourceNames.add(exploratoryName);
- List<BillingReportLine> billingData = billingDAO.findBillingData(project, endpoint, resourceNames);
- final double sum = billingData.stream().mapToDouble(BillingReportLine::getCost).sum();
+ List<BillingReportLine> billingReportLines = billingDAO.findBillingData(project, endpoint, resourceNames);
+ final double sum = billingReportLines.stream().mapToDouble(BillingReportLine::getCost).sum();
+ //Scale the resource costs for WEB UI
Review comment:
Comment has been removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #808: [DLAB-1720] Minor fix for exploratory report
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #808:
URL: https://github.com/apache/incubator-dlab/pull/808#discussion_r449130022
##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/BillingServiceImpl.java
##########
@@ -140,8 +140,13 @@ public String downloadReport(UserInfo user, BillingFilter filter) {
public BillingReport getExploratoryBillingData(String project, String endpoint, String exploratoryName, List<String> compNames) {
List<String> resourceNames = new ArrayList<>(compNames);
resourceNames.add(exploratoryName);
- List<BillingReportLine> billingData = billingDAO.findBillingData(project, endpoint, resourceNames);
- final double sum = billingData.stream().mapToDouble(BillingReportLine::getCost).sum();
+ List<BillingReportLine> billingReportLines = billingDAO.findBillingData(project, endpoint, resourceNames);
+ final double sum = billingReportLines.stream().mapToDouble(BillingReportLine::getCost).sum();
+ //Scale the resource costs for WEB UI
Review comment:
Please remove this comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org