[GitHub] [incubator-superset] ktmud commented on pull request #10251: docs: pointers to plugins blog post

[GitBox <gi...@apache.org>]

ktmud commented on pull request #10251:
URL: https://github.com/apache/incubator-superset/pull/10251#issuecomment-654596615


   This is definitely useful content to share! Awesome work and thanks for putting this together, @evans !
   
   Two questions:
   
   1. The blog post seems to be encouraging people to share their plugins, but `CONTRIBUTING.md` still kind of discourages it.
   
      Blog post:
   
      > If <strike>your</strike> (typo here BTW) your plugin is something you think the entire Superset community can make use of, feel free to open a pull request to superset-ui! For plugins that are more experimental, or for specialized/rare use cases, we plan to provide a better means to publish such viz plugins in the near future (and let you know about it here!).
   
      incubator-superset/CONTRIBUTING.md:
   
      > Superset is working towards a plugin system where new visualizations can be installed as optional npm packages. To achieve this goal, we are not accepting pull requests for new community-contributed visualization types at the moment. However, bugfixes for current visualizations are welcome.
   
      While they do not necessarily conflict with each other, do you think there's a need to reconcile the tones?
   
   2. The FAQ page already has <strike>a section</strike> [two](https://superset.incubator.apache.org/faq.html#how-do-i-create-my-own-visualization) [questions](https://superset.incubator.apache.org/faq.html#how-do-i-go-about-developing-a-new-visualization-type) about creating new visualizations. Maybe merge and update?
   
   I'm also a little concerned about adding links to an external resource that is not part of the Superset project. Apart from the risk of content being outdated, permlinks moved, etc, there also seems to be a conflict of interest that I simply couldn't overlook. Are we comfortable this is how we wanna manage the docs (and potentially new feature releases---there's language like _"let you know about it here"_ in the blog post)? What about other contents Preset may create in the future? And what if some other people want to add their own tutorial posts to the official docs?
   
   Don't get me wrong, Preset has done a great deal of valuable work for viz plugins and we must give credit where credit's due---just wanted to make sure our practice is prudent and future-proof here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org