You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/22 08:25:00 UTC

[GitHub] [cordova-js] raphinesse opened a new pull request #208: Make built JS output a bit prettier

raphinesse opened a new pull request #208: Make built JS output a bit prettier
URL: https://github.com/apache/cordova-js/pull/208
 
 
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   In #205 I took great care to preserve the _exact_ format of the built
   JS code, so the build refactoring could be verified by diffing the
   build output. However, some of the existing formatting is sub-optimal
   so this commit optimizes it a little.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Most notably, this commit will change file path comments to be relative
   paths, not absolute ones. An example for this:
   
   ```diff
   -// file: /home/raphinesse/code/cordova-android/cordova-js-src/exec.js
   +// file: ../cordova-android/cordova-js-src/exec.js
   ```
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   I diffed the build artifacts and verified that the diff was as expected. Except for the test build, the diff only consists of whitespace and comments. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org