[GitHub] shazron commented on a change in pull request #450: fix issue #447

[GitBox <gi...@apache.org>]

shazron commented on a change in pull request #450: fix issue #447
URL: https://github.com/apache/cordova-ios/pull/450#discussion_r246265208
 
 

 ##########
 File path: CordovaLib/Classes/Private/Plugins/CDVUIWebViewEngine/CDVUIWebViewDelegate.m
 ##########
 @@ -329,9 +329,14 @@ - (void)webViewDidFinishLoad:(UIWebView*)webView
             break;
 
         case STATE_WAITING_FOR_LOAD_FINISH:
-            if (_loadCount == 1) {
+            // fix call loadRequest multiple times just callback webViewDidFinishLoad once time in iOS 12
+            if (@available(iOS 12.0, *)) {
 
 Review comment:
   Like @janpio said, you need to test for iOS 12 and greater. Use `IsAtLeastiOSVersion` https://github.com/apache/cordova-ios/blob/1cf92246d5463f519bab76e573078a76d58f9c68/CordovaLib/Classes/Public/CDVAvailability.h#L96 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org