[GitHub] [flink] rmetzger commented on a change in pull request #14767: [FLINK-21099] Introduce JobType to distinguish between batch and streaming jobs

[GitBox <gi...@apache.org>]

rmetzger commented on a change in pull request #14767:
URL: https://github.com/apache/flink/pull/14767#discussion_r565327342



##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorBatchExecutionTest.java
##########
@@ -105,6 +107,7 @@ public void testOneInputTransformation() {
         assertThat(graph.getStateBackend(), instanceOf(BatchExecutionStateBackend.class));
         // the provider is passed as a lambda therefore we cannot assert the class of the provider
         assertThat(graph.getTimerServiceProvider(), notNullValue());
+        assertThat(graph.getJobType(), is(JobType.BATCH));

Review comment:
       > I'm not really sold on this shotgun-style assertion approach.
   
   My thinking was the following: All tests seem to assert a bunch of assumptions (batch state backend, timer service set etc.) .. since this is the style of the tests there, I added the BATCH job type everywhere.
   I was too lazy adding a separate batch job-type test, since I assumed enough coverage through the other change.
   
   I will follow your suggestion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org