You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "dengzhhu653 (via GitHub)" <gi...@apache.org> on 2023/12/14 04:42:29 UTC
[PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
dengzhhu653 opened a new pull request, #4948:
URL: https://github.com/apache/hive/pull/4948
…ompose
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### Is the change a dependency upgrade?
<!--
If yes, please attach a file with output from mvn dependency:tree to validate a complete upgrade of dependency.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1855199212
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4948) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4948&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4948&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4948)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427876511
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
do you run with this command?
```shell
MAVEN_LOCAL_REPOSITORY=`mvn help:evaluate -Dexpression=settings.localRepository -q -DforceStdout` docker compose up -d ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427658535
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
Should we download the postgres jar automatically while spinning up the cluster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1892941192
@zhangbutao @aturoczy @ayushtkn @deniskuzZ Thank you for the comment and try!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427625137
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
Currently we use postgres 42.5.1 in our project, it's easy for user to change the version or download the jar as they wish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 merged PR #4948:
URL: https://github.com/apache/hive/pull/4948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1862116330
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4948) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4948&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4948&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4948)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427998714
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
```
ayushsaxena@ayushsaxena docker % export HIVE_VERSION=4.0.0-beta-1
ayushsaxena@ayushsaxena docker % MAVEN_LOCAL_REPOSITORY=`mvn help:evaluate -Dexpression=settings.localRepository -q -DforceStdout` docker compose up -d
[+] Running 15/15
✔ hiveserver2 Pulled 61.0s
✔ metastore 13 layers [⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿] 0B/0B Pulled 61.0s
✔ a9fe95647e78 Already exists 0.0s
✔ 4015b6e8cc8d Already exists 0.0s
✔ 0e86b181efa0 Already exists 0.0s
✔ 94abd992e68d Already exists 0.0s
✔ e7a78026257f Pull complete 54.0s
✔ 3874402c80d6 Pull complete 56.1s
✔ a8c0cb8787a3 Pull complete 56.2s
✔ 7e494428637a Pull complete 56.2s
✔ 64e47b23d332 Pull complete 56.2s
✔ f9c33c65d8ef Pull complete 56.2s
✔ 885d438fb370 Pull complete 56.2s
✔ 340aa3eab0dc Pull complete 56.2s
✔ 4f4fb700ef54 Pull complete 56.3s
[+] Building 0.0s (0/0)
[+] Running 0/1
⠏ Container metastore Creating 136.7s
```
It got hung again, I think because in my maven local repo there is no postgres jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1891278848
> @dengzhhu653, looks like POSTGRES_LOCAL_PATH is not optional, so you can't simply do `docker compose down`
>
> ```
> docker compose down
>
> WARN[0000] The "POSTGRES_LOCAL_PATH" variable is not set. Defaulting to a blank string.
> invalid mount config for type "bind": field Source must not be empty
> ```
@deniskuzZ, I move `POSTGRES_LOCAL_PATH` as an env variable, user can set it according to their environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427658008
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
For me it is printing
```
WARN[0000] The "MAVEN_LOCAL_REPOSITORY" variable is not set. Defaulting to a blank string.
```
So, I need to set ``MAVEN_LOCAL_REPOSITORY`` explicitly first to use it?
And then it kind of got hung creating metastore
```
WARN[0000] The "MAVEN_LOCAL_REPOSITORY" variable is not set. Defaulting to a blank string.
[+] Building 0.0s (0/0)
[+] Running 1/2
✔ Container postgres Created 0.0s
⠧ Container metastore Creating 103.5s
```
It is 100+ seconds and still going on as I write this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1857146843
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4948) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4948&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4948&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4948)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1857098559
> Why do we need to load the postgre jdbc driver by default? (Sorry for noob question, but I do not see the permanent value from this code)
>
> btw this jar is under BSDS-2 license. https://jdbc.postgresql.org/license/
>
> After I read It, seems like we met the requirement. I just post here, to double check by others. It is jus
This fix doesn't package the postgres jar into the tar ball, it shows how to solve the missing driver in the example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427510196
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
does it assumes the maven local repo will be having postgresql-42.5.1.jar always?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1427876511
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
do you run with this command?
```shell
MAVEN_LOCAL_REPOSITORY=`mvn help:evaluate -Dexpression=settings.localRepository -q -DforceStdout` docker compose up -d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4948:
URL: https://github.com/apache/hive/pull/4948#discussion_r1432093541
##########
packaging/src/docker/docker-compose.yml:
##########
@@ -32,6 +32,9 @@ services:
- '9083:9083'
volumes:
- warehouse:/opt/hive/data/warehouse
+ - type: bind
+ source: ${MAVEN_LOCAL_REPOSITORY}/org/postgresql/postgresql/42.5.1/postgresql-42.5.1.jar
Review Comment:
Hi @ayushtkn, I have updated the command, which tries to download the postgres jar into maven local repo, cloud you run this command please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27955: Missing Postgres driver when start services from Docker c… [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #4948:
URL: https://github.com/apache/hive/pull/4948#issuecomment-1889056497
@dengzhhu653, looks like POSTGRES_LOCAL_PATH is not optional, so you can't simply do `docker compose down`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org