You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/10/22 22:31:00 UTC
[commons-pool] 02/02: - Use for each loop in test. - Remove unused
import in test.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 2d2049233940b10c7dd35df70a353d383f601053
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Oct 22 18:30:46 2019 -0400
- Use for each loop in test.
- Remove unused import in test.
---
src/test/java/org/apache/commons/pool2/TestObjectPool.java | 1 -
.../org/apache/commons/pool2/impl/TestAbandonedObjectPool.java | 7 +++----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/TestObjectPool.java b/src/test/java/org/apache/commons/pool2/TestObjectPool.java
index 3808ce0..3f317cb 100644
--- a/src/test/java/org/apache/commons/pool2/TestObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/TestObjectPool.java
@@ -22,7 +22,6 @@ import org.apache.commons.pool2.ObjectPool;
import org.apache.commons.pool2.PooledObjectFactory;
import org.apache.commons.pool2.impl.GenericObjectPool;
import org.apache.commons.pool2.impl.SoftReferenceObjectPool;
-import org.apache.commons.pool2.PoolUtils;
import org.junit.Test;
import java.util.List;
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
index 2b90d79..7579d2e 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
@@ -104,8 +104,8 @@ public class TestAbandonedObjectPool {
}
// Abandon all borrowed objects
- for (int i = 0; i < vec.size(); i++) {
- vec.get(i).setAbandoned(true);
+ for (final PooledTestObject element : vec) {
+ element.setAbandoned(true);
}
// Try launching a bunch of borrows concurrently. Abandoned sweep will be triggered for each.
@@ -122,8 +122,7 @@ public class TestAbandonedObjectPool {
}
// Return all objects that have not been destroyed
- for (int i = 0; i < vec.size(); i++) {
- final PooledTestObject pto = vec.get(i);
+ for (final PooledTestObject pto : vec) {
if (pto.isActive()) {
pool.returnObject(pto);
}