You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2026/03/30 21:05:48 UTC
(maven-surefire) branch master updated: Remove FIXME which has been fixed :) (#3339)
This is an automated email from the ASF dual-hosted git repository.
olamy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
The following commit(s) were added to refs/heads/master by this push:
new 64856f440 Remove FIXME which has been fixed :) (#3339)
64856f440 is described below
commit 64856f44022df8deda81eed996279d224dc4bd20
Author: Olivier Lamy <ol...@apache.org>
AuthorDate: Tue Mar 31 07:05:43 2026 +1000
Remove FIXME which has been fixed :) (#3339)
* Remove FIXME which has been fixed :)
Signed-off-by: Olivier Lamy <ol...@apache.org>
* spotless
Signed-off-by: Olivier Lamy <ol...@apache.org>
---------
Signed-off-by: Olivier Lamy <ol...@apache.org>
---
.../org/apache/maven/plugin/surefire/AbstractSurefireMojo.java | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
index 4cb575ae5..676e9cdc6 100644
--- a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
+++ b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
@@ -3159,18 +3159,16 @@ public Set<Artifact> getProviderClasspath() throws MojoExecutionException {
}
}
if (testNgArtifact != null) {
- // FIXME support only from TestNG 6.14.3
- // FIXME check if already present as plugin dependency or project dependency
+ // minimum testng version tested via getTestNgArtifact
String junitSupportGroupId = "org.junit.support";
String testNgEngineArtifactId = "testng-engine";
String testNgEngineCoordinates = junitSupportGroupId + ":" + testNgEngineArtifactId;
- // FIXME configurable?
- // or picked from test dependencies
- String version = "1.0.6";
- consoleLogger.debug("TestNG is present. Resolving " + testNgEngineCoordinates + ":" + version);
+ String version = "1.1.0";
if (!testDeps.containsKey(testNgEngineCoordinates)
&& !pluginDeps.containsKey(testNgEngineCoordinates)) {
addEngineByApi(junitSupportGroupId, testNgEngineArtifactId, version, providerArtifacts);
+ consoleLogger.info(
+ "TestNG is present. Adding per default " + testNgEngineCoordinates + ":" + version);
}
}