You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:03:30 UTC
[GitHub] [wicket] martin-g commented on a diff in pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)
martin-g commented on code in PR #540:
URL: https://github.com/apache/wicket/pull/540#discussion_r985722371
##########
pom.xml:
##########
@@ -891,18 +894,19 @@
<extensions>true</extensions>
<executions>
<execution>
- <id>bundle-manifest</id>
- <phase>process-classes</phase>
+ <id>default-bundle</id>
+ <phase>package</phase>
<goals>
- <goal>manifest</goal>
+ <goal>bundle</goal>
</goals>
<configuration>
<instructions>
- <Export-Package>*</Export-Package>
- <Import-Package>org.apache.wicket*,
- org.junit.jupiter*</Import-Package>
- <DynamicImport-Package>*</DynamicImport-Package>
+ <Require-Capability>osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11.0))"</Require-Capability>
Review Comment:
This probably should be version 17.0 for `master` and `11` for wicket-9.x
##########
pom.xml:
##########
@@ -891,18 +894,19 @@
<extensions>true</extensions>
<executions>
<execution>
- <id>bundle-manifest</id>
- <phase>process-classes</phase>
+ <id>default-bundle</id>
+ <phase>package</phase>
<goals>
- <goal>manifest</goal>
+ <goal>bundle</goal>
</goals>
<configuration>
<instructions>
- <Export-Package>*</Export-Package>
- <Import-Package>org.apache.wicket*,
- org.junit.jupiter*</Import-Package>
- <DynamicImport-Package>*</DynamicImport-Package>
+ <Require-Capability>osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11.0))"</Require-Capability>
+ <Export-Package>${osgi.export.package}</Export-Package>
+ <Import-Package>${osgi.import.package}</Import-Package>
+ <DynamicImport-Package>${osgi.dynamicimport.package}</DynamicImport-Package>
<_nouses>true</_nouses>
+ <!-- _noee>true</_noee -->
Review Comment:
This could be removed, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org