You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "haohuaijin (via GitHub)" <gi...@apache.org> on 2023/10/19 14:29:57 UTC
[PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
haohuaijin opened a new pull request, #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
the `div_ceil()` is already stable.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on PR #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872#issuecomment-1771222657
I find this is because `div_ceil()` is stable in rust version 1.73, so msrv should be 1.73, but `core`'s cargo.toml set `rust-version=1.70`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin closed pull request #7872: Minor: replace `bit_util::ceil()` to `div_ceil()`
URL: https://github.com/apache/arrow-datafusion/pull/7872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on code in PR #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872#discussion_r1365771217
##########
datafusion-cli/Cargo.toml:
##########
@@ -25,7 +25,7 @@ keywords = ["arrow", "datafusion", "query", "sql"]
license = "Apache-2.0"
homepage = "https://github.com/apache/arrow-datafusion"
repository = "https://github.com/apache/arrow-datafusion"
-rust-version = "1.70"
+rust-version = "1.73"
Review Comment:
agree,thanks for your explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872#issuecomment-1773177612
So perhaps we should sit on this PR for some time (6 months?) until 1.73 has been out for a longer time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872#issuecomment-1771123658
FYI I believe this will implicitly bump the MSRV of datafusion to the latest of 1.73 - I'm not sure what the policy on this is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872#discussion_r1365749723
##########
datafusion-cli/Cargo.toml:
##########
@@ -25,7 +25,7 @@ keywords = ["arrow", "datafusion", "query", "sql"]
license = "Apache-2.0"
homepage = "https://github.com/apache/arrow-datafusion"
repository = "https://github.com/apache/arrow-datafusion"
-rust-version = "1.70"
+rust-version = "1.73"
Review Comment:
It is fairly standard practice to set the MSRV to accommodate at least a couple of older versions, I'm not sure what DataFusion's policy is, but updating to 1.73 which was only released 9 days ago would be a very aggressive posture.
For comparison arrow-rs has an MSRV of 1.62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: replace `bit_util::ceil()` to `div_ceil()` [arrow-datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on code in PR #7872:
URL: https://github.com/apache/arrow-datafusion/pull/7872#discussion_r1365771217
##########
datafusion-cli/Cargo.toml:
##########
@@ -25,7 +25,7 @@ keywords = ["arrow", "datafusion", "query", "sql"]
license = "Apache-2.0"
homepage = "https://github.com/apache/arrow-datafusion"
repository = "https://github.com/apache/arrow-datafusion"
-rust-version = "1.70"
+rust-version = "1.73"
Review Comment:
agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org