[GitHub] [solr] patsonluk commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

["patsonluk (via GitHub)" <gi...@apache.org>]

patsonluk commented on code in PR #1762:
URL: https://github.com/apache/solr/pull/1762#discussion_r1258962825


##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {
   private static void addReplica(String syntheticCollectionName, CoreContainer cores) {
     SolrQueryResponse rsp = new SolrQueryResponse();
     try {
+      String coreName = syntheticCollectionName + "_" + "r1";

Review Comment:
   Do we want to include node name as a part of the core name? otherwise 2 coordinator nodes might use same name for the replica?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org