You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by duksis <gi...@git.apache.org> on 2017/06/05 12:08:37 UTC
[GitHub] incubator-predictionio pull request #390: Fix duplicate org name
GitHub user duksis opened a pull request:
https://github.com/apache/incubator-predictionio/pull/390
Fix duplicate org name
<img width="894" alt="screen shot 2017-06-05 at 13 51 45" src="https://cloud.githubusercontent.com/assets/222101/26783428/611434f8-49f8-11e7-9b5b-2d4f2dd656be.png">
template repo in all the cases where this is used is passed in as a github slug "org/repo" and ends up having broken links with duplicate org in them.
https://github.com/apache/incubator-predictionio/blob/livedoc/docs/manual/source/templates/vanilla/quickstart.html.md.erb#L49
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duksis/incubator-predictionio patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit 10d7f4356e4db3d9ddfee0b8f473109862cd033d
Author: Hugo Duksis <du...@users.noreply.github.com>
Date: 2017-06-05T11:55:57Z
Fix duplicate org name
template repo in all the cases where this is used is passed in as a github slug "org/repo" and ends up having broken links with duplicate org in them.
https://github.com/apache/incubator-predictionio/blob/livedoc/docs/manual/source/templates/vanilla/quickstart.html.md.erb#L49
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #390: Fix duplicate org name
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/390
@duksis asfgit closes it automatically when your change is merged to develop. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #390: Fix duplicate org name
Posted by duksis <gi...@git.apache.org>.
Github user duksis commented on the issue:
https://github.com/apache/incubator-predictionio/pull/390
maybe github did not like the capital C :)
I guess its fine to close it manually
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #390: Fix duplicate org name
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/390
I already merged this pull request into both of `livedoc` and `develop` branch, but it has not been closed automatically. It's strange...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #390: Fix duplicate org name
Posted by duksis <gi...@git.apache.org>.
Github user duksis closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---