You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Amruta Borkar <ar...@us.ibm.com> on 2017/05/24 19:30:10 UTC
Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
Bugs: AMBARI-21104
https://issues.apache.org/jira/browse/AMBARI-21104
Repository: ambari
Description
-------
Add Confirmation pop up for 'Generate Blueprint' button.
Notify user that two files will be downloaded and provide information on how to use those files.
Diffs
-----
ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9260ba123fdc165d680100f15641c22
ambari-web/app/messages.js 0c15a1935e5109689678e46eea01bfde532ce0e7
ambari-web/app/templates/wizard/step8.hbs 907b3d4bbfc859020f553b282452dd5f62cb9725
Diff: https://reviews.apache.org/r/59532/diff/1/
Testing
-------
Tested manually. Attached image of the Confirmation box.
File Attachments
----------------
Generate_blueprint_confirmation
https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png
Thanks,
Amruta Borkar
Re: Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
Posted by Amruta Borkar <ar...@us.ibm.com>.
> On May 24, 2017, 8:24 p.m., Di Li wrote:
> > ambari-web/app/messages.js
> > Lines 974 (patched)
> > <https://reviews.apache.org/r/59532/diff/1/?file=1731664#file1731664line974>
> >
> > Can we update the msg to the following (I removed details on how bp register rest call), where XXXX is dynamically replaced by the cluster name the user typed in on the UI ?
> >
> > ... ...
> > You will be downloading blueprint.json and clustertemplate.json to your local machine.
> >
> > You can use them to deploy a cluster via AMBARI REST API.
> > Update clustertemplate.json with a custom cluster name if you do not want to use xxxx.
> >
> > If you want to use custom repo URLs, make sure to update them via Ambari REST API before deploying the cluster.
Hello Di,
Please review the updated patch.
- Amruta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review175987
-----------------------------------------------------------
On May 24, 2017, 10:17 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:17 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how to use those files.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9
> ambari-web/app/messages.js 0c15a1935e
> ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf
>
>
> Diff: https://reviews.apache.org/r/59532/diff/2/
>
>
> Testing
> -------
>
> Tested manually. Attached image of the Confirmation box.
>
>
> File Attachments
> ----------------
>
> Generate_blueprint_confirmation
> https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review175987
-----------------------------------------------------------
ambari-web/app/messages.js
Lines 974 (patched)
<https://reviews.apache.org/r/59532/#comment249334>
Can we update the msg to the following (I removed details on how bp register rest call), where XXXX is dynamically replaced by the cluster name the user typed in on the UI ?
... ...
You will be downloading blueprint.json and clustertemplate.json to your local machine.
You can use them to deploy a cluster via AMBARI REST API.
Update clustertemplate.json with a custom cluster name if you do not want to use xxxx.
If you want to use custom repo URLs, make sure to update them via Ambari REST API before deploying the cluster.
- Di Li
On May 24, 2017, 7:30 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 7:30 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how to use those files.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9260ba123fdc165d680100f15641c22
> ambari-web/app/messages.js 0c15a1935e5109689678e46eea01bfde532ce0e7
> ambari-web/app/templates/wizard/step8.hbs 907b3d4bbfc859020f553b282452dd5f62cb9725
>
>
> Diff: https://reviews.apache.org/r/59532/diff/1/
>
>
> Testing
> -------
>
> Tested manually. Attached image of the Confirmation box.
>
>
> File Attachments
> ----------------
>
> Generate_blueprint_confirmation
> https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review176025
-----------------------------------------------------------
Ship it!
Ship It!
- Sangeeta Ravindran
On May 24, 2017, 10:43 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:43 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how to use those files.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9
> ambari-web/app/messages.js 0c15a1935e
> ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf
>
>
> Diff: https://reviews.apache.org/r/59532/diff/2/
>
>
> Testing
> -------
>
> Tested manually. Attached image of the Confirmation box.
>
>
> File Attachments
> ----------------
>
> Confirmation pop up
> https://reviews.apache.org/media/uploaded/files/2017/05/24/b708ef1d-6a7f-4525-9dee-ecb11ab6d5fa__Snip20170524_9.png
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review176064
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On May 24, 2017, 10:43 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:43 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how to use those files.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9
> ambari-web/app/messages.js 0c15a1935e
> ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf
>
>
> Diff: https://reviews.apache.org/r/59532/diff/2/
>
>
> Testing
> -------
>
> Tested manually. Attached image of the Confirmation box.
>
>
> File Attachments
> ----------------
>
> Confirmation pop up
> https://reviews.apache.org/media/uploaded/files/2017/05/24/b708ef1d-6a7f-4525-9dee-ecb11ab6d5fa__Snip20170524_9.png
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
Posted by Amruta Borkar <ar...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/
-----------------------------------------------------------
(Updated May 24, 2017, 10:43 p.m.)
Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
Bugs: AMBARI-21104
https://issues.apache.org/jira/browse/AMBARI-21104
Repository: ambari
Description
-------
Add Confirmation pop up for 'Generate Blueprint' button.
Notify user that two files will be downloaded and provide information on how to use those files.
Diffs
-----
ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9
ambari-web/app/messages.js 0c15a1935e
ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf
Diff: https://reviews.apache.org/r/59532/diff/2/
Testing
-------
Tested manually. Attached image of the Confirmation box.
File Attachments (updated)
----------------
Confirmation pop up
https://reviews.apache.org/media/uploaded/files/2017/05/24/b708ef1d-6a7f-4525-9dee-ecb11ab6d5fa__Snip20170524_9.png
Thanks,
Amruta Borkar
Re: Review Request 59532: Add Confirmation pop up for 'Generate
Blueprint' button
Posted by Amruta Borkar <ar...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/
-----------------------------------------------------------
(Updated May 24, 2017, 10:17 p.m.)
Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
Bugs: AMBARI-21104
https://issues.apache.org/jira/browse/AMBARI-21104
Repository: ambari
Description
-------
Add Confirmation pop up for 'Generate Blueprint' button.
Notify user that two files will be downloaded and provide information on how to use those files.
Diffs (updated)
-----
ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9
ambari-web/app/messages.js 0c15a1935e
ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf
Diff: https://reviews.apache.org/r/59532/diff/2/
Changes: https://reviews.apache.org/r/59532/diff/1-2/
Testing
-------
Tested manually. Attached image of the Confirmation box.
File Attachments
----------------
Generate_blueprint_confirmation
https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png
Thanks,
Amruta Borkar