[Bug 59712] If HTTP post message body data has %pa% the Results Tree can't show the message

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59712

Teemu Vesala <Te...@qentinel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Teemu Vesala <Te...@qentinel.com> ---
The problem is at the code snippet below. Returning null when the decoding
fails for IllegalArgumentExpcetion prevents showing the message at all. I'd
change this to return non-decoded query. I've attached the diff about that
modification. It didn't add any new unit test error messages.  

    public static String decodeQuery(String query) {
        if (query != null && query.length() > 0) {
            try {
                query = URLDecoder.decode(query, CHARSET_DECODE); // better
ISO-8859-1 than UTF-8
            } catch(IllegalArgumentException e) {
                log.warn("Error decoding query, maybe your request parameters
should be encoded:" + query, e);
                return null;
            } catch (UnsupportedEncodingException uee) {
                log.warn("Error decoding query, maybe your request parameters
should be encoded:" + query, uee);
                return null;
            } 
            return query;
        }
        return null;
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.