[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1216: MINIFICPP-1290 Create test coverage for OPC processors

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1216:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1216#discussion_r758141425



##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -141,7 +141,7 @@ def check_for_multiple_files_generated(self, file_count, timeout_seconds, expect
     def check_for_at_least_one_file_with_content_generated(self, content, timeout_seconds):
         output_validator = SingleOrMultiFileOutputValidator(decode_escaped_str(content))
         output_validator.set_output_dir(self.file_system_observer.get_output_dir())
-        self.check_output(timeout_seconds, output_validator, 1)
+        self.check_output(timeout_seconds, output_validator, timeout_seconds)

Review comment:
       This is actually intentional, because we want to allow more files to be generated and only check if at least one has the content we desire. The timeout seconds seemed to be a good limit as we do not generate more files than one every second.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org