You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/09/10 21:17:01 UTC
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23414
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
The AdminCliTest.TestRebuildTables often (almost certainly) fails when
running under TSAN with --stress_cpu_threads=N, where N is the number
of CPU cores on the test machine. With the increase of the number
of retries and timeout intervals it might require several minutes to
complete if running with --stress_cpu_threads=N. With that, I think
the most appropriate resolution is simply not run it under TSAN:
we do have enough coverage for the functionality with RELEASE, DEBUG,
and ASAN builds, and the building blocks of the scenario are covered
in TSAN builds in many other test scenarios.
In addition, this changelist adds SKIP_IF_SLOW_NOT_ALLOWED() into the
scenario: in my experiments, the fastest run of RELEASE bits of this
scenario was about 5 seconds on 8 core 2GHz CPU machine without
--stress_cpu_threads, while the informal threshold for slow Kudu tests
is 3 seconds.
Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/23414/1
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23414 )
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1790/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 22:48:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23414 )
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 21:34:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23414 )
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
Patch Set 1: Verified+1
unrelated failures of known flaky Java tests in DEBUG, RELEASE, TSAN builds
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 22:52:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23414 )
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1790/
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 21:17:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23414 )
Change subject: KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
......................................................................
KUDU-3660 do not run AdminCliTest.TestRebuildTables under TSAN
The AdminCliTest.TestRebuildTables often (almost certainly) fails when
running under TSAN with --stress_cpu_threads=N, where N is the number
of CPU cores on the test machine. With the increase of the number
of retries and timeout intervals it might require several minutes to
complete if running with --stress_cpu_threads=N. With that, I think
the most appropriate resolution is simply not run it under TSAN:
we do have enough coverage for the functionality with RELEASE, DEBUG,
and ASAN builds, and the building blocks of the scenario are covered
in TSAN builds in many other test scenarios.
In addition, this changelist adds SKIP_IF_SLOW_NOT_ALLOWED() into the
scenario: in my experiments, the fastest run of RELEASE bits of this
scenario was about 5 seconds on 8 core 2GHz CPU machine without
--stress_cpu_threads, while the informal threshold for slow Kudu tests
is 3 seconds.
Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Reviewed-on: http://gerrit.cloudera.org:8080/23414
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia09bba0cb6f014ffd46529d4fec607e19caf1d2c
Gerrit-Change-Number: 23414
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>